issue_comments

Table actions

2 rows where issue = 599074389 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • interpolate_na drops DataArray attributes · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
613465209 https://github.com/pydata/xarray/issues/3968#issuecomment-613465209 https://api.github.com/repos/pydata/xarray/issues/3968 MDEyOklzc3VlQ29tbWVudDYxMzQ2NTIwOQ== RobWatersMet 40356437 2020-04-14T14:08:54Z 2020-04-14T14:08:54Z NONE

Hi Tom,

thanks for the information and timely response.

Cheers,

Rob

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   interpolate_na drops DataArray attributes 599074389
613462193 https://github.com/pydata/xarray/issues/3968#issuecomment-613462193 https://api.github.com/repos/pydata/xarray/issues/3968 MDEyOklzc3VlQ29tbWVudDYxMzQ2MjE5Mw== TomNicholas 35968931 2020-04-14T14:03:32Z 2020-04-14T14:03:32Z MEMBER

Hi Rob,

Thanks for flagging this. It was a bug, which I've now fixed in a PR.

My fix adds a keep_attrs argument to interpolate_na in order to be consistent with the rest of the API. That means to preserve the attrs you'll either have to pass keep_attrs=True explicitly, or set the global option with xr.set_options(keep_attrs=True). I would recommend doing the latter, and then please raise another issue if you spot any other methods which don't preserve attrs.

I do not believe attributes should ever be dropped like this as they typically contain persistent information.

I basically agree, but we're discussing the details of whether or not to change to this behaviour as the default over in #3891 .

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   interpolate_na drops DataArray attributes 599074389

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);