issue_comments: 613462193

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/3968#issuecomment-613462193 https://api.github.com/repos/pydata/xarray/issues/3968 613462193 MDEyOklzc3VlQ29tbWVudDYxMzQ2MjE5Mw== 35968931 2020-04-14T14:03:32Z 2020-04-14T14:03:32Z MEMBER

Hi Rob,

Thanks for flagging this. It was a bug, which I've now fixed in a PR.

My fix adds a keep_attrs argument to interpolate_na in order to be consistent with the rest of the API. That means to preserve the attrs you'll either have to pass keep_attrs=True explicitly, or set the global option with xr.set_options(keep_attrs=True). I would recommend doing the latter, and then please raise another issue if you spot any other methods which don't preserve attrs.

I do not believe attributes should ever be dropped like this as they typically contain persistent information.

I basically agree, but we're discussing the details of whether or not to change to this behaviour as the default over in #3891 .

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   599074389