issue_comments

Table actions

3 rows where issue = 592312709 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • max-sixty · 3 ✖

issue 1

  • sel along 1D non-index coordinates · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
609821244 https://github.com/pydata/xarray/pull/3925#issuecomment-609821244 https://api.github.com/repos/pydata/xarray/issues/3925 MDEyOklzc3VlQ29tbWVudDYwOTgyMTI0NA== max-sixty 5635139 2020-04-06T14:14:34Z 2020-04-06T14:14:34Z MEMBER

OK! May be a sizeable change but I update on @shoyer 's view, let's do it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   sel along 1D non-index coordinates 592312709
608014672 https://github.com/pydata/xarray/pull/3925#issuecomment-608014672 https://api.github.com/repos/pydata/xarray/issues/3925 MDEyOklzc3VlQ29tbWVudDYwODAxNDY3Mg== max-sixty 5635139 2020-04-02T18:01:11Z 2020-04-02T18:01:11Z MEMBER

Sorry, could you explain what you mean here? How would this PR violate that?

Of course. I mean that if someone changes the dimensionality of a non-index coord from 1D to 2D, then running .sel over it will stop working.

Whereas now, neither would work. Which in some ways is worse, but also less surprising. I think these are always difficult trade-offs...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   sel along 1D non-index coordinates 592312709
607977635 https://github.com/pydata/xarray/pull/3925#issuecomment-607977635 https://api.github.com/repos/pydata/xarray/issues/3925 MDEyOklzc3VlQ29tbWVudDYwNzk3NzYzNQ== max-sixty 5635139 2020-04-02T17:14:41Z 2020-04-02T17:14:41Z MEMBER

I think the functionality is useful, but I'm concerned it would make the API more confusing. In particular, one maxim we've generally held is that changing the number of dimensions doesn't change functionality. (ofc it changes whether it's possible to create an index, though the indexing API doesn't change)

What are others' thoughts?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   sel along 1D non-index coordinates 592312709

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);