issue_comments

Table actions

5 rows where issue = 591471233 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Add missing_dims argument allowing isel() to ignore missing dimensions · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
608626318 https://github.com/pydata/xarray/pull/3923#issuecomment-608626318 https://api.github.com/repos/pydata/xarray/issues/3923 MDEyOklzc3VlQ29tbWVudDYwODYyNjMxOA== max-sixty 5635139 2020-04-03T19:47:01Z 2020-04-03T19:47:01Z MEMBER

Great, thanks a lot @johnomotani !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add missing_dims argument allowing isel() to ignore missing dimensions 591471233
608325265 https://github.com/pydata/xarray/pull/3923#issuecomment-608325265 https://api.github.com/repos/pydata/xarray/issues/3923 MDEyOklzc3VlQ29tbWVudDYwODMyNTI2NQ== keewis 14808389 2020-04-03T09:12:21Z 2020-04-03T09:12:21Z MEMBER

you're right, that's #3928

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add missing_dims argument allowing isel() to ignore missing dimensions 591471233
608324523 https://github.com/pydata/xarray/pull/3923#issuecomment-608324523 https://api.github.com/repos/pydata/xarray/issues/3923 MDEyOklzc3VlQ29tbWVudDYwODMyNDUyMw== johnomotani 3958036 2020-04-03T09:10:41Z 2020-04-03T09:10:41Z CONTRIBUTOR

The Linux-py38-upstream-dev test is failing in cftime tests at various places similar to this ``` with create_tmp_file() as tmp_file: original.to_netcdf(tmp_file) with pytest.warns(None) as record: with open_dataset(tmp_file, use_cftime=False) as ds: assert_identical(expected_x, ds.x) assert_identical(expected_time, ds.time)

          assert not record

E assert not WarningsChecker(record=True) ``` Don't think it's related to this PR...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add missing_dims argument allowing isel() to ignore missing dimensions 591471233
608167928 https://github.com/pydata/xarray/pull/3923#issuecomment-608167928 https://api.github.com/repos/pydata/xarray/issues/3923 MDEyOklzc3VlQ29tbWVudDYwODE2NzkyOA== dcherian 2448579 2020-04-03T00:42:39Z 2020-04-03T00:42:39Z MEMBER

I don't see why Dataset.isel is different.

+1 for using the drop_vars kwarg

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add missing_dims argument allowing isel() to ignore missing dimensions 591471233
608104318 https://github.com/pydata/xarray/pull/3923#issuecomment-608104318 https://api.github.com/repos/pydata/xarray/issues/3923 MDEyOklzc3VlQ29tbWVudDYwODEwNDMxOA== max-sixty 5635139 2020-04-02T21:39:16Z 2020-04-02T21:39:16Z MEMBER

Thanks @johnomotani ; appreciate the PR.

I'm not strongly opposed to this. I haven't personally had an instance where I've wanted this keyword, but that's not overly representative of others' cases. What do people think, @pydata/xarray ?

Separately, if we do merge, I think we should align with the keywords on drop_vars: raise / ignore

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add missing_dims argument allowing isel() to ignore missing dimensions 591471233

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);