home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 608104318

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3923#issuecomment-608104318 https://api.github.com/repos/pydata/xarray/issues/3923 608104318 MDEyOklzc3VlQ29tbWVudDYwODEwNDMxOA== 5635139 2020-04-02T21:39:16Z 2020-04-02T21:39:16Z MEMBER

Thanks @johnomotani ; appreciate the PR.

I'm not strongly opposed to this. I haven't personally had an instance where I've wanted this keyword, but that's not overly representative of others' cases. What do people think, @pydata/xarray ?

Separately, if we do merge, I think we should align with the keywords on drop_vars: raise / ignore

{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  591471233
Powered by Datasette · Queries took 0.543ms · About: xarray-datasette