issue_comments

Table actions

2 rows where issue = 587895591 and user = 6213168 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • crusaderky · 2 ✖

issue 1

  • Keep attrs by default? (keep_attrs) · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
604665945 https://github.com/pydata/xarray/issues/3891#issuecomment-604665945 https://api.github.com/repos/pydata/xarray/issues/3891 MDEyOklzc3VlQ29tbWVudDYwNDY2NTk0NQ== crusaderky 6213168 2020-03-26T20:24:23Z 2020-03-26T20:24:23Z MEMBER

@shoyer to me this it would make the most sense to do a union of the inputs: - if a key is present only in one input, it goes to the output - if a key is present in multiple inputs, always take the leftmost

Note how this would be different from how scalar coords are treated; scalar coords are discarded when they arrive from multiple inputs and are mismatched. The reason I don't think it's wise to do the same with attrs is that it could be uncontrollably expensive to compute equality, depending on what people loaded in them. I've personally seen them used as back-references to the whole application framework. Also there's no guarantee that they implement __eq__ or that it returns a bool; e.g. you can't compare two data structures that somewhere inside contain numpy arrays.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Keep attrs by default? (keep_attrs) 587895591
604310958 https://github.com/pydata/xarray/issues/3891#issuecomment-604310958 https://api.github.com/repos/pydata/xarray/issues/3891 MDEyOklzc3VlQ29tbWVudDYwNDMxMDk1OA== crusaderky 6213168 2020-03-26T09:03:50Z 2020-03-26T09:03:50Z MEMBER

Why would you want a .drop_attrs() method? .attrs.clear() will do just fine. I fully agree we should keep attrs by default.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Keep attrs by default? (keep_attrs) 587895591

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);