issue_comments: 604665945

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/3891#issuecomment-604665945 https://api.github.com/repos/pydata/xarray/issues/3891 604665945 MDEyOklzc3VlQ29tbWVudDYwNDY2NTk0NQ== 6213168 2020-03-26T20:24:23Z 2020-03-26T20:24:23Z MEMBER

@shoyer to me this it would make the most sense to do a union of the inputs: - if a key is present only in one input, it goes to the output - if a key is present in multiple inputs, always take the leftmost

Note how this would be different from how scalar coords are treated; scalar coords are discarded when they arrive from multiple inputs and are mismatched. The reason I don't think it's wise to do the same with attrs is that it could be uncontrollably expensive to compute equality, depending on what people loaded in them. I've personally seen them used as back-references to the whole application framework. Also there's no guarantee that they implement __eq__ or that it returns a bool; e.g. you can't compare two data structures that somewhere inside contain numpy arrays.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   587895591