issue_comments

Table actions

7 rows where issue = 584837010 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • max-sixty · 7 ✖

issue 1

  • Implement idxmax and idxmin functions · 7 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
605588070 https://github.com/pydata/xarray/pull/3871#issuecomment-605588070 https://api.github.com/repos/pydata/xarray/issues/3871 MDEyOklzc3VlQ29tbWVudDYwNTU4ODA3MA== max-sixty 5635139 2020-03-29T06:02:19Z 2020-03-29T06:02:19Z MEMBER

@toddrjen thank you again! This ended up being quite an adventure, really appreciate you pushing all the way. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement idxmax and idxmin functions 584837010
605540515 https://github.com/pydata/xarray/pull/3871#issuecomment-605540515 https://api.github.com/repos/pydata/xarray/issues/3871 MDEyOklzc3VlQ29tbWVudDYwNTU0MDUxNQ== max-sixty 5635139 2020-03-29T00:55:43Z 2020-03-29T00:55:43Z MEMBER

Amazing — let's merge on green!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement idxmax and idxmin functions 584837010
605387218 https://github.com/pydata/xarray/pull/3871#issuecomment-605387218 https://api.github.com/repos/pydata/xarray/issues/3871 MDEyOklzc3VlQ29tbWVudDYwNTM4NzIxOA== max-sixty 5635139 2020-03-28T03:18:53Z 2020-03-28T03:18:53Z MEMBER

Thank you again @toddrjen, both for the content and the iteration.

@shoyer any final thoughts? Otherwise I'll merge tomorrow?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement idxmax and idxmin functions 584837010
602138813 https://github.com/pydata/xarray/pull/3871#issuecomment-602138813 https://api.github.com/repos/pydata/xarray/issues/3871 MDEyOklzc3VlQ29tbWVudDYwMjEzODgxMw== max-sixty 5635139 2020-03-22T02:32:53Z 2020-03-22T02:32:53Z MEMBER

LGTM! Any other thoughts before we merge?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement idxmax and idxmin functions 584837010
601991643 https://github.com/pydata/xarray/pull/3871#issuecomment-601991643 https://api.github.com/repos/pydata/xarray/issues/3871 MDEyOklzc3VlQ29tbWVudDYwMTk5MTY0Mw== max-sixty 5635139 2020-03-21T04:13:32Z 2020-03-21T04:13:32Z MEMBER

Do you mean non-dimension coordinates?

Yes, thanks for clarifying

Does that even make sense in a general way? If they are 1D and tied to just one dimension coordinate that could be done, but if they are not tied to any dimension or tied to multiple dimensions or otherwise not 1D I am not sure what it would mean to take the idxmin/idxmax of them.

Yes, it wouldn't work in all cases, fair point. There are some cases in which it would work though, I'm unsure if it would be too complicated an interface to return them depending on whether it would work.

(and completely fine to contemplate these later)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement idxmax and idxmin functions 584837010
601989897 https://github.com/pydata/xarray/pull/3871#issuecomment-601989897 https://api.github.com/repos/pydata/xarray/issues/3871 MDEyOklzc3VlQ29tbWVudDYwMTk4OTg5Nw== max-sixty 5635139 2020-03-21T03:57:00Z 2020-03-21T03:57:00Z MEMBER

The one complication is that using DataArray.idxmax and DataArray.idxmin assumes that the Dataset would only ever contain DataArray objects

I hear you and share the impulse that baking this in seems not ideal. Though I think it's a reasonable compromise to make, and there are no plans to deviate from it.

(Ideally maybe we have a ._contained_class attribute on the dataset which is almost always DataArray)

I think having a lambda is fine too.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement idxmax and idxmin functions 584837010
601814285 https://github.com/pydata/xarray/pull/3871#issuecomment-601814285 https://api.github.com/repos/pydata/xarray/issues/3871 MDEyOklzc3VlQ29tbWVudDYwMTgxNDI4NQ== max-sixty 5635139 2020-03-20T17:12:46Z 2020-03-20T17:12:46Z MEMBER

This looks extremely good and thorough! Thanks @toddrjen !

I'll have a proper look through later. I see a couple of minor questions I'll add in too. Others feel free to get ahead of me!

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement idxmax and idxmin functions 584837010

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);