issues: 584837010

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
584837010 MDExOlB1bGxSZXF1ZXN0MzkxMzQ2OTQz 3871 Implement idxmax and idxmin functions 2272878 closed 0     20 2020-03-20T04:27:32Z 2020-03-31T15:43:48Z 2020-03-29T01:54:25Z CONTRIBUTOR   0 pydata/xarray/pulls/3871

This implements idxmax and idxmin functions similar to thier pandas equivalents.

This is my first time contributing to the project so I am not certain the structure or approach is the best. Please let me know if there is a better way to implement this.

This also includes two other changes.

First, it drops some code for backwards-compatibility with numpy 1.12, which isn't supported. This code was hiding an error I needed to have access to in order to get the function working.

Second, it adds an option to Dataset.map to let you map DataArray methods by name. I used this to implement the Dataset versions of idxmax and idxmin.

  • [X] Closes #60
  • [X] Tests added
  • [X] Passes isort -rc . && black . && mypy . && flake8
  • [X] Fully documented, including whats-new.rst for all changes and api.rst for new API
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/3871/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables