issue_comments

Table actions

3 rows where issue = 582708100 and user = 29104956 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • rsokl · 3 ✖

issue 1

  • Raise error when assigning to IndexVariable.values & IndexVariable.data · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
612146195 https://github.com/pydata/xarray/pull/3862#issuecomment-612146195 https://api.github.com/repos/pydata/xarray/issues/3862 MDEyOklzc3VlQ29tbWVudDYxMjE0NjE5NQ== rsokl 29104956 2020-04-10T17:58:50Z 2020-04-10T17:58:50Z NONE

Ah! Nice! Yeah the error message led me to believe that there was no path for in-place updates.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Raise error when assigning to IndexVariable.values & IndexVariable.data 582708100
612141362 https://github.com/pydata/xarray/pull/3862#issuecomment-612141362 https://api.github.com/repos/pydata/xarray/issues/3862 MDEyOklzc3VlQ29tbWVudDYxMjE0MTM2Mg== rsokl 29104956 2020-04-10T17:47:14Z 2020-04-10T17:47:14Z NONE

That's exactly what this change does, making assignment to IndexVariable.values an error.

Sorry, I got a bit criss-crossed between this PR and the thread in #3470.

In light of https://github.com/pydata/xarray/issues/3470#issuecomment-566214653 it seems like the next best thing would be to given assign_coords the optional ability to update the DataArray/DataSet in-place. Thoughts? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Raise error when assigning to IndexVariable.values & IndexVariable.data 582708100
612095122 https://github.com/pydata/xarray/pull/3862#issuecomment-612095122 https://api.github.com/repos/pydata/xarray/issues/3862 MDEyOklzc3VlQ29tbWVudDYxMjA5NTEyMg== rsokl 29104956 2020-04-10T15:59:41Z 2020-04-10T15:59:41Z NONE

@dcherian @max-sixty is there a reason why this change wasn't incorporated into values.setter? This change blocks the ability to update coordinate values in-place. This breaks code in a more fundamental way than just requiring users to rely on assign_coords - it can necessitate a substantial change in code design for people who were relying on the ability to mutate coordinates. This also leads me to ask: was it really appropriate to call such a substantial breaking change only a patch? 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Raise error when assigning to IndexVariable.values & IndexVariable.data 582708100

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);