home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 612095122

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3862#issuecomment-612095122 https://api.github.com/repos/pydata/xarray/issues/3862 612095122 MDEyOklzc3VlQ29tbWVudDYxMjA5NTEyMg== 29104956 2020-04-10T15:59:41Z 2020-04-10T15:59:41Z NONE

@dcherian @max-sixty is there a reason why this change wasn't incorporated into values.setter? This change blocks the ability to update coordinate values in-place. This breaks code in a more fundamental way than just requiring users to rely on assign_coords - it can necessitate a substantial change in code design for people who were relying on the ability to mutate coordinates. This also leads me to ask: was it really appropriate to call such a substantial breaking change only a patch?

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  582708100
Powered by Datasette · Queries took 1.024ms · About: xarray-datasette