issue_comments

Table actions

2 rows where issue = 56817968 and user = 141709 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • sjpfenninger · 2 ✖

issue 1

  • Not-quite-ISO timestamps · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
73732815 https://github.com/pydata/xarray/issues/316#issuecomment-73732815 https://api.github.com/repos/pydata/xarray/issues/316 MDEyOklzc3VlQ29tbWVudDczNzMyODE1 sjpfenninger 141709 2015-02-10T16:37:16Z 2015-02-10T16:37:16Z CONTRIBUTOR

I noticed that you already have a fallback option and I simply made use of that, which solves this problem in a way that looks reasonable to me.

However, I'm still not quite happy with the way errors were/are handled: before this change, reading a file with the non-standard datetime format would work without errors, but trying to do anything with the dataset after opening it would produce a ValueError, which from an end-user perspective doesn't help much to figure out where the error is coming from.

I suppose with the change in my PR, for cases where python-netCDF4 is not installed, one would instead get an ImportError without explanation (one wouldn't know why we tried to import the optional dependency). Maybe something like a wrapper to import netCDF4 which raises a context-specific ImportError message would be useful?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Not-quite-ISO timestamps 56817968
73519971 https://github.com/pydata/xarray/issues/316#issuecomment-73519971 https://api.github.com/repos/pydata/xarray/issues/316 MDEyOklzc3VlQ29tbWVudDczNTE5OTcx sjpfenninger 141709 2015-02-09T14:47:39Z 2015-02-09T14:47:39Z CONTRIBUTOR

I think falling back to netcdftime would be preferrable to a datetime_format argument since it would just automagically work (although a datetime_format could be useful for other, trickier netCDF files). I could have a go at doing this later in the week and submit a PR, if it's helpful.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Not-quite-ISO timestamps 56817968

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);