issue_comments: 73732815
This data as json
| html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
|---|---|---|---|---|---|---|---|---|---|---|---|
| https://github.com/pydata/xarray/issues/316#issuecomment-73732815 | https://api.github.com/repos/pydata/xarray/issues/316 | 73732815 | MDEyOklzc3VlQ29tbWVudDczNzMyODE1 | 141709 | 2015-02-10T16:37:16Z | 2015-02-10T16:37:16Z | CONTRIBUTOR | I noticed that you already have a fallback option and I simply made use of that, which solves this problem in a way that looks reasonable to me. However, I'm still not quite happy with the way errors were/are handled: before this change, reading a file with the non-standard datetime format would work without errors, but trying to do anything with the dataset after opening it would produce a ValueError, which from an end-user perspective doesn't help much to figure out where the error is coming from. I suppose with the change in my PR, for cases where python-netCDF4 is not installed, one would instead get an ImportError without explanation (one wouldn't know why we tried to import the optional dependency). Maybe something like a wrapper to import netCDF4 which raises a context-specific ImportError message would be useful? |
{
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} |
56817968 |