issue_comments

Table actions

3 rows where issue = 553930127 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • reduce on groupby auto-adds axis argument and complains when axis argument is specified · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
577936734 https://github.com/pydata/xarray/issues/3717#issuecomment-577936734 https://api.github.com/repos/pydata/xarray/issues/3717 MDEyOklzc3VlQ29tbWVudDU3NzkzNjczNA== aidanheerdegen 6063709 2020-01-24T00:08:50Z 2020-01-24T00:08:50Z CONTRIBUTOR

Thanks @ScottWales.

So using dim and not axis works, as you might expect given Scott's explanation.

So for anyone having this issue, a work-around is to specify dim if possible.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   reduce on groupby auto-adds axis argument and complains when axis argument is specified 553930127
577929592 https://github.com/pydata/xarray/issues/3717#issuecomment-577929592 https://api.github.com/repos/pydata/xarray/issues/3717 MDEyOklzc3VlQ29tbWVudDU3NzkyOTU5Mg== ScottWales 161133 2020-01-23T23:42:27Z 2020-01-23T23:42:27Z CONTRIBUTOR

In the reduce call https://github.com/pydata/xarray/blob/6d1434e9b9e9766d6fcafceb05e81734b29994ea/xarray/core/groupby.py#L877-L888

dim is assigned to a default of self._group_dim if it hasn't been specified. This should also check if axis hasn't been set.

The check_reduce_dims() call should then have a check for dim is None as well, so it's not run if axis is being used.

That should get you started

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   reduce on groupby auto-adds axis argument and complains when axis argument is specified 553930127
577733963 https://github.com/pydata/xarray/issues/3717#issuecomment-577733963 https://api.github.com/repos/pydata/xarray/issues/3717 MDEyOklzc3VlQ29tbWVudDU3NzczMzk2Mw== dcherian 2448579 2020-01-23T15:33:45Z 2020-01-23T15:33:45Z MEMBER

Thanks for opening an issue @aidanheerdegen

We added this check recently: https://github.com/pydata/xarray/blob/6d1434e9b9e9766d6fcafceb05e81734b29994ea/xarray/core/groupby.py#L27-L36

but it seems like it's unnecessary given the docstring. (I don't really understand .reduce).

Are you up for sending in a PR to remove that check?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   reduce on groupby auto-adds axis argument and complains when axis argument is specified 553930127

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);