home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 577733963

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/3717#issuecomment-577733963 https://api.github.com/repos/pydata/xarray/issues/3717 577733963 MDEyOklzc3VlQ29tbWVudDU3NzczMzk2Mw== 2448579 2020-01-23T15:33:45Z 2020-01-23T15:33:45Z MEMBER

Thanks for opening an issue @aidanheerdegen

We added this check recently: https://github.com/pydata/xarray/blob/6d1434e9b9e9766d6fcafceb05e81734b29994ea/xarray/core/groupby.py#L27-L36

but it seems like it's unnecessary given the docstring. (I don't really understand .reduce).

Are you up for sending in a PR to remove that check?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  553930127
Powered by Datasette · Queries took 3.116ms · About: xarray-datasette