issue_comments

Table actions

6 rows where issue = 552896124 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 4

author_association 2

issue 1

  • PseudoNetCDF tests failing randomly · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
602840290 https://github.com/pydata/xarray/issues/3711#issuecomment-602840290 https://api.github.com/repos/pydata/xarray/issues/3711 MDEyOklzc3VlQ29tbWVudDYwMjg0MDI5MA== max-sixty 5635139 2020-03-23T20:32:32Z 2020-03-23T20:32:32Z MEMBER

Should we disable this one test if there's not an immediate solution to hand?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   PseudoNetCDF tests failing randomly 552896124
579882516 https://github.com/pydata/xarray/issues/3711#issuecomment-579882516 https://api.github.com/repos/pydata/xarray/issues/3711 MDEyOklzc3VlQ29tbWVudDU3OTg4MjUxNg== keewis 14808389 2020-01-29T17:59:52Z 2020-01-29T17:59:52Z MEMBER

I just noticed that this is not restricted to windows, this also randomly fails for other CI suites.

3728 fixes the formatting issue so now the cause of the errors should not be hidden anymore.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   PseudoNetCDF tests failing randomly 552896124
578259713 https://github.com/pydata/xarray/issues/3711#issuecomment-578259713 https://api.github.com/repos/pydata/xarray/issues/3711 MDEyOklzc3VlQ29tbWVudDU3ODI1OTcxMw== barronh 1191149 2020-01-24T19:06:34Z 2020-01-24T19:06:34Z CONTRIBUTOR

Let me know if you need my input, but I think the testcase solution is more general than PseudoNetCDF.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   PseudoNetCDF tests failing randomly 552896124
577760478 https://github.com/pydata/xarray/issues/3711#issuecomment-577760478 https://api.github.com/repos/pydata/xarray/issues/3711 MDEyOklzc3VlQ29tbWVudDU3Nzc2MDQ3OA== keewis 14808389 2020-01-23T16:31:18Z 2020-01-23T16:46:38Z MEMBER

the dataset is from xarray/tests/data/example.uamiv and when opening it we can see that VGLVLS is indeed not a scalar: VGLVLS: [1. 0.]

While trying to reproduce the error, I noticed that the bit of code above does not get called unless expected.identical(actual) == False. This means we actually have two bugs: one that makes _diff_mapping_repr choke on non-scalar (ndarray?) attributes and should be easy to fix, and another one that to me seems random (look at the commits of #3706: the last two don't fail while https://github.com/pydata/xarray/pull/3706/commits/1e07dce4b8fd59057d22ae3d7884a1114c78e22a fails) and makes expected different from actual.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   PseudoNetCDF tests failing randomly 552896124
576848923 https://github.com/pydata/xarray/issues/3711#issuecomment-576848923 https://api.github.com/repos/pydata/xarray/issues/3711 MDEyOklzc3VlQ29tbWVudDU3Njg0ODkyMw== barronh 1191149 2020-01-21T19:46:14Z 2020-01-21T19:46:14Z CONTRIBUTOR

I want to make sure I understand the genesis of the error. My guess is that if you added a print(k) statement, you'd see that this is failing on the VGLVLS attribute. Is that right?

If so, I'm guessing the error is that VGLVLS is not a scalar. NetCDF files and uamiv files may have attributes with values. This is the case for VGLVLS in the IOAPI format, which uamiv is made to emulate.

As a result, compatible is an array not a scalar. A simple solution would be to wrap compatible in a call to all.

Can you confirm which attribute this is failing on and what the value of compatible is when it fails?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   PseudoNetCDF tests failing randomly 552896124
576738984 https://github.com/pydata/xarray/issues/3711#issuecomment-576738984 https://api.github.com/repos/pydata/xarray/issues/3711 MDEyOklzc3VlQ29tbWVudDU3NjczODk4NA== dcherian 2448579 2020-01-21T15:37:49Z 2020-01-21T15:37:49Z MEMBER

cc @barronh 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   PseudoNetCDF tests failing randomly 552896124

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);