issue_comments: 577760478

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/3711#issuecomment-577760478 https://api.github.com/repos/pydata/xarray/issues/3711 577760478 MDEyOklzc3VlQ29tbWVudDU3Nzc2MDQ3OA== 14808389 2020-01-23T16:31:18Z 2020-01-23T16:46:38Z MEMBER

the dataset is from xarray/tests/data/example.uamiv and when opening it we can see that VGLVLS is indeed not a scalar: VGLVLS: [1. 0.]

While trying to reproduce the error, I noticed that the bit of code above does not get called unless expected.identical(actual) == False. This means we actually have two bugs: one that makes _diff_mapping_repr choke on non-scalar (ndarray?) attributes and should be easy to fix, and another one that to me seems random (look at the commits of #3706: the last two don't fail while https://github.com/pydata/xarray/pull/3706/commits/1e07dce4b8fd59057d22ae3d7884a1114c78e22a fails) and makes expected different from actual.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   552896124