issue_comments

Table actions

3 rows where issue = 549712566 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • mypy --strict fails on scripts/packages depending on xarray; __all__ required · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
575371718 https://github.com/pydata/xarray/issues/3695#issuecomment-575371718 https://api.github.com/repos/pydata/xarray/issues/3695 MDEyOklzc3VlQ29tbWVudDU3NTM3MTcxOA== aldanor 2418513 2020-01-16T22:13:55Z 2020-01-16T22:13:55Z NONE

Any thoughts?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   mypy --strict fails on scripts/packages depending on xarray; __all__ required 549712566
574555353 https://github.com/pydata/xarray/issues/3695#issuecomment-574555353 https://api.github.com/repos/pydata/xarray/issues/3695 MDEyOklzc3VlQ29tbWVudDU3NDU1NTM1Mw== aldanor 2418513 2020-01-15T08:43:10Z 2020-01-15T08:43:10Z NONE 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   mypy --strict fails on scripts/packages depending on xarray; __all__ required 549712566
574545528 https://github.com/pydata/xarray/issues/3695#issuecomment-574545528 https://api.github.com/repos/pydata/xarray/issues/3695 MDEyOklzc3VlQ29tbWVudDU3NDU0NTUyOA== shoyer 1217238 2020-01-15T08:13:38Z 2020-01-15T08:13:38Z MEMBER

I'm a little surprised that mypy cares about __all__. For our __init__.py file, we are actually pretty careful to only define variables that are in xarray's public API, so __all__ was otherwise redundant.

In principle I have no objection to adding this, but it would be nice to if you could dig up a reference that explains mypy's behavior.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   mypy --strict fails on scripts/packages depending on xarray; __all__ required 549712566

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);