home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 574545528

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/3695#issuecomment-574545528 https://api.github.com/repos/pydata/xarray/issues/3695 574545528 MDEyOklzc3VlQ29tbWVudDU3NDU0NTUyOA== 1217238 2020-01-15T08:13:38Z 2020-01-15T08:13:38Z MEMBER

I'm a little surprised that mypy cares about __all__. For our __init__.py file, we are actually pretty careful to only define variables that are in xarray's public API, so __all__ was otherwise redundant.

In principle I have no objection to adding this, but it would be nice to if you could dig up a reference that explains mypy's behavior.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  549712566
Powered by Datasette · Queries took 0.525ms · About: xarray-datasette