issue_comments

Table actions

3 rows where issue = 539988974 and user = 3460034 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • jthielen · 3 ✖

issue 1

  • Pint support for DataArray · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
610159680 https://github.com/pydata/xarray/pull/3643#issuecomment-610159680 https://api.github.com/repos/pydata/xarray/issues/3643 MDEyOklzc3VlQ29tbWVudDYxMDE1OTY4MA== jthielen 3460034 2020-04-07T03:58:05Z 2020-04-07T03:58:05Z CONTRIBUTOR

Also, after glancing through all this, it seems like xarray is dealing inconsistently with the type casting hierarchy:

Should this be its own issue?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Pint support for DataArray 539988974
610159608 https://github.com/pydata/xarray/pull/3643#issuecomment-610159608 https://api.github.com/repos/pydata/xarray/issues/3643 MDEyOklzc3VlQ29tbWVudDYxMDE1OTYwOA== jthielen 3460034 2020-04-07T03:57:45Z 2020-04-07T03:57:45Z CONTRIBUTOR

@keewis Is part of the specific problem that Pint has a guarded import of xarray when defining its upcast types? Would it help if it checked for the fully qualified class name instead?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Pint support for DataArray 539988974
569166918 https://github.com/pydata/xarray/pull/3643#issuecomment-569166918 https://api.github.com/repos/pydata/xarray/issues/3643 MDEyOklzc3VlQ29tbWVudDU2OTE2NjkxOA== jthielen 3460034 2019-12-27T02:09:45Z 2019-12-27T02:09:45Z CONTRIBUTOR

@jthielen, it looks like this needs numpy.pad and numpy.resize in pint. I tried to implement it myself, but while numpy.resize is easy (add an entry to the implement_consistent_units_by_argument loop), that is not the case for numpy.pad. Regardless of whether my proposed fixes are actually the best way, numpy.pad is used in other places of the code base so we'd probably need both, anyway. What do you think?

No problem at all to add these! See https://github.com/hgrecco/pint/pull/956.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Pint support for DataArray 539988974

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);