home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 610159680

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3643#issuecomment-610159680 https://api.github.com/repos/pydata/xarray/issues/3643 610159680 MDEyOklzc3VlQ29tbWVudDYxMDE1OTY4MA== 3460034 2020-04-07T03:58:05Z 2020-04-07T03:58:05Z CONTRIBUTOR

Also, after glancing through all this, it seems like xarray is dealing inconsistently with the type casting hierarchy:

  • Construction/wrapping allowing __array_function__-defining duck arrays among other explictly listed additions (pandas.Index, dask arrays, etc., see https://github.com/pydata/xarray/blob/9b5140e0711247c373987b56726282140b406d7f/xarray/core/variable.py#L166)
  • Binary ops only denying based on xarray's internal hierarchy (Dataset, DataArray, Variable), otherwise deferring to underlying data
  • __array_ufunc__ allowing a list of supported types (https://github.com/pydata/xarray/blob/9b5140e0711247c373987b56726282140b406d7f/xarray/core/arithmetic.py#L24-L30 along with SupportsArithmetic)
  • (__array_function__ yet to be defined)

Should this be its own issue?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  539988974
Powered by Datasette · Queries took 0.681ms · About: xarray-datasette