issue_comments

Table actions

5 rows where issue = 539394615 and user = 13301940 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • andersy005 · 5 ✖

issue 1

  • Add entrypoint for plotting backends · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
927385227 https://github.com/pydata/xarray/pull/3640#issuecomment-927385227 https://api.github.com/repos/pydata/xarray/issues/3640 IC_kwDOAMm_X843RsaL andersy005 13301940 2021-09-26T22:47:10Z 2021-09-26T22:47:10Z MEMBER

Do we not want to discuss this in the bi-weekly dev meetings perhaps?

👍🏽 I'm in favor of discussing this in the dev meetings... Being able to easily switch plotting backends would be a nice feature to have from a user's perspective. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add entrypoint for plotting backends 539394615
927378300 https://github.com/pydata/xarray/pull/3640#issuecomment-927378300 https://api.github.com/repos/pydata/xarray/issues/3640 IC_kwDOAMm_X843Rqt8 andersy005 13301940 2021-09-26T21:53:42Z 2021-09-26T21:53:42Z MEMBER

Closing this because it has gone stale :(

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add entrypoint for plotting backends 539394615
619573052 https://github.com/pydata/xarray/pull/3640#issuecomment-619573052 https://api.github.com/repos/pydata/xarray/issues/3640 MDEyOklzc3VlQ29tbWVudDYxOTU3MzA1Mg== andersy005 13301940 2020-04-26T15:48:00Z 2020-04-26T15:49:49Z MEMBER

What's the current status here?

I put this PR on a back burner :). As I pointed out in https://github.com/pydata/xarray/pull/3640#issuecomment-580413432, it is my understand that xarray will need to define a minimal plotting API for this entrypoint feature to work properly. Would this plotting API be something xarray devs would be willing to have/support? Cc @shoyer @dcherian @jhamman

I could be missing something here. So please let me know if there is another way of getting the entrypoint feature to work without needing to define a plotting API that third-party visualization libraries adheres to.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add entrypoint for plotting backends 539394615
580413432 https://github.com/pydata/xarray/pull/3640#issuecomment-580413432 https://api.github.com/repos/pydata/xarray/issues/3640 MDEyOklzc3VlQ29tbWVudDU4MDQxMzQzMg== andersy005 13301940 2020-01-30T19:23:30Z 2020-01-30T19:23:30Z MEMBER

After looking at Pandas source code, it's my understanding that - Pandas provides a well defined plotting API - At runtime, Pandas figures out the right backend to use via _get_plot_backend() and then dispatches the plotting functionality to this backend.

This approach makes interfacing with Pandas objects easy as long as the plotting library adheres to this plotting API. Currently, Xarray's plotting API is closely tied to matplotlib. To support entrypoint for other plotting backend will likely require defining something similar to Pandas's plotting API. Is my interpretation correct?

Pinging @TomAugspurger, @jsignell and @jbednar as they may have ideas on how to proceed with this implementation. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add entrypoint for plotting backends 539394615
580313388 https://github.com/pydata/xarray/pull/3640#issuecomment-580313388 https://api.github.com/repos/pydata/xarray/issues/3640 MDEyOklzc3VlQ29tbWVudDU4MDMxMzM4OA== andersy005 13301940 2020-01-30T15:42:22Z 2020-01-30T15:42:22Z MEMBER

can you summarize what's needed on the holoviews and xarray side for this to work?

A while back I opened this issue https://github.com/holoviz/hvplot/issues/392. I am about to make modifications to hvplot/holoviews locally to test that this PR is going to work as expected. Once I have a better understanding of what's needed, I will report back. 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add entrypoint for plotting backends 539394615

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);