issue_comments

Table actions

14 rows where issue = 539394615 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • Add entrypoint for plotting backends · 14 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
927901750 https://github.com/pydata/xarray/pull/3640#issuecomment-927901750 https://api.github.com/repos/pydata/xarray/issues/3640 IC_kwDOAMm_X843Tqg2 TomNicholas 35968931 2021-09-27T13:58:49Z 2021-09-27T13:58:49Z MEMBER

There is a dev meeting this Wednesday (occurring every fortnight), would be great to see you there!

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add entrypoint for plotting backends 539394615
927892524 https://github.com/pydata/xarray/pull/3640#issuecomment-927892524 https://api.github.com/repos/pydata/xarray/issues/3640 IC_kwDOAMm_X843ToQs jsignell 4806877 2021-09-27T13:48:08Z 2021-09-27T13:48:08Z CONTRIBUTOR

I'm sorry I missed pings on this. I am happy to join the dev meeting if that'd be helpful or I can just start paying better attention :roll_eyes: 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add entrypoint for plotting backends 539394615
927385227 https://github.com/pydata/xarray/pull/3640#issuecomment-927385227 https://api.github.com/repos/pydata/xarray/issues/3640 IC_kwDOAMm_X843RsaL andersy005 13301940 2021-09-26T22:47:10Z 2021-09-26T22:47:10Z MEMBER

Do we not want to discuss this in the bi-weekly dev meetings perhaps?

👍🏽 I'm in favor of discussing this in the dev meetings... Being able to easily switch plotting backends would be a nice feature to have from a user's perspective. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add entrypoint for plotting backends 539394615
927383712 https://github.com/pydata/xarray/pull/3640#issuecomment-927383712 https://api.github.com/repos/pydata/xarray/issues/3640 IC_kwDOAMm_X843RsCg TomNicholas 35968931 2021-09-26T22:34:12Z 2021-09-26T22:34:19Z MEMBER

it is my understand that xarray will need to define a minimal plotting API for this entrypoint feature to work properly. Would this plotting API be something xarray devs would be willing to have/support?

Do we not want to discuss this in the bi-weekly dev meetings perhaps? (Apologies if it has been and I just missed it.) This seems like a good idea to implement!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add entrypoint for plotting backends 539394615
927378300 https://github.com/pydata/xarray/pull/3640#issuecomment-927378300 https://api.github.com/repos/pydata/xarray/issues/3640 IC_kwDOAMm_X843Rqt8 andersy005 13301940 2021-09-26T21:53:42Z 2021-09-26T21:53:42Z MEMBER

Closing this because it has gone stale :(

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add entrypoint for plotting backends 539394615
619573052 https://github.com/pydata/xarray/pull/3640#issuecomment-619573052 https://api.github.com/repos/pydata/xarray/issues/3640 MDEyOklzc3VlQ29tbWVudDYxOTU3MzA1Mg== andersy005 13301940 2020-04-26T15:48:00Z 2020-04-26T15:49:49Z MEMBER

What's the current status here?

I put this PR on a back burner :). As I pointed out in https://github.com/pydata/xarray/pull/3640#issuecomment-580413432, it is my understand that xarray will need to define a minimal plotting API for this entrypoint feature to work properly. Would this plotting API be something xarray devs would be willing to have/support? Cc @shoyer @dcherian @jhamman

I could be missing something here. So please let me know if there is another way of getting the entrypoint feature to work without needing to define a plotting API that third-party visualization libraries adheres to.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add entrypoint for plotting backends 539394615
619061738 https://github.com/pydata/xarray/pull/3640#issuecomment-619061738 https://api.github.com/repos/pydata/xarray/issues/3640 MDEyOklzc3VlQ29tbWVudDYxOTA2MTczOA== philippjfr 1550771 2020-04-24T14:56:21Z 2020-04-24T14:56:21Z NONE

To be clear, I'm just checking whether there's anything that I can or need to do in hvPlot so this can proceed smoothly.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add entrypoint for plotting backends 539394615
619061196 https://github.com/pydata/xarray/pull/3640#issuecomment-619061196 https://api.github.com/repos/pydata/xarray/issues/3640 MDEyOklzc3VlQ29tbWVudDYxOTA2MTE5Ng== philippjfr 1550771 2020-04-24T14:55:28Z 2020-04-24T14:55:28Z NONE

@andersy005 Sorry I never followed up here. Trying to get out a new hvPlot release very soon. What's the current status here? @jsignell do you have any comments?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add entrypoint for plotting backends 539394615
580462361 https://github.com/pydata/xarray/pull/3640#issuecomment-580462361 https://api.github.com/repos/pydata/xarray/issues/3640 MDEyOklzc3VlQ29tbWVudDU4MDQ2MjM2MQ== TomAugspurger 1312546 2020-01-30T21:13:09Z 2020-01-30T21:13:09Z MEMBER

Is my interpretation correct?

Yep, that's the basic idea. Every call to DataFrame.plot.<kind> begins with a check for the active backend. Based on the configured value, we the correct backend, make the call, and return the result.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add entrypoint for plotting backends 539394615
580413432 https://github.com/pydata/xarray/pull/3640#issuecomment-580413432 https://api.github.com/repos/pydata/xarray/issues/3640 MDEyOklzc3VlQ29tbWVudDU4MDQxMzQzMg== andersy005 13301940 2020-01-30T19:23:30Z 2020-01-30T19:23:30Z MEMBER

After looking at Pandas source code, it's my understanding that - Pandas provides a well defined plotting API - At runtime, Pandas figures out the right backend to use via _get_plot_backend() and then dispatches the plotting functionality to this backend.

This approach makes interfacing with Pandas objects easy as long as the plotting library adheres to this plotting API. Currently, Xarray's plotting API is closely tied to matplotlib. To support entrypoint for other plotting backend will likely require defining something similar to Pandas's plotting API. Is my interpretation correct?

Pinging @TomAugspurger, @jsignell and @jbednar as they may have ideas on how to proceed with this implementation. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add entrypoint for plotting backends 539394615
580313388 https://github.com/pydata/xarray/pull/3640#issuecomment-580313388 https://api.github.com/repos/pydata/xarray/issues/3640 MDEyOklzc3VlQ29tbWVudDU4MDMxMzM4OA== andersy005 13301940 2020-01-30T15:42:22Z 2020-01-30T15:42:22Z MEMBER

can you summarize what's needed on the holoviews and xarray side for this to work?

A while back I opened this issue https://github.com/holoviz/hvplot/issues/392. I am about to make modifications to hvplot/holoviews locally to test that this PR is going to work as expected. Once I have a better understanding of what's needed, I will report back. 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add entrypoint for plotting backends 539394615
580308750 https://github.com/pydata/xarray/pull/3640#issuecomment-580308750 https://api.github.com/repos/pydata/xarray/issues/3640 MDEyOklzc3VlQ29tbWVudDU4MDMwODc1MA== dcherian 2448579 2020-01-30T15:32:12Z 2020-01-30T15:32:12Z MEMBER

@andersy005 can you summarize what's needed on the holoviews and xarray side for this to work?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add entrypoint for plotting backends 539394615
580231944 https://github.com/pydata/xarray/pull/3640#issuecomment-580231944 https://api.github.com/repos/pydata/xarray/issues/3640 MDEyOklzc3VlQ29tbWVudDU4MDIzMTk0NA== crusaderky 6213168 2020-01-30T12:33:58Z 2020-01-30T12:33:58Z MEMBER

if you merge from master you should get all green on the upstream-dev test now

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 1,
    "eyes": 0
}
   Add entrypoint for plotting backends 539394615
566826787 https://github.com/pydata/xarray/pull/3640#issuecomment-566826787 https://api.github.com/repos/pydata/xarray/issues/3640 MDEyOklzc3VlQ29tbWVudDU2NjgyNjc4Nw== dcherian 2448579 2019-12-18T01:35:16Z 2019-12-18T01:35:16Z MEMBER

EXCITING!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add entrypoint for plotting backends 539394615

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);