issue_comments

Table actions

11 rows where issue = 533580931 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

author_association 2

issue 1

  • Fix pint integration tests · 11 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
563345805 https://github.com/pydata/xarray/pull/3600#issuecomment-563345805 https://api.github.com/repos/pydata/xarray/issues/3600 MDEyOklzc3VlQ29tbWVudDU2MzM0NTgwNQ== max-sixty 5635139 2019-12-09T17:30:08Z 2019-12-09T17:30:08Z MEMBER

Thank you @keewis !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix pint integration tests 533580931
563213288 https://github.com/pydata/xarray/pull/3600#issuecomment-563213288 https://api.github.com/repos/pydata/xarray/issues/3600 MDEyOklzc3VlQ29tbWVudDU2MzIxMzI4OA== keewis 14808389 2019-12-09T12:20:16Z 2019-12-09T12:20:16Z MEMBER

thanks for reviewing and merging, @max-sixty 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix pint integration tests 533580931
563165561 https://github.com/pydata/xarray/pull/3600#issuecomment-563165561 https://api.github.com/repos/pydata/xarray/issues/3600 MDEyOklzc3VlQ29tbWVudDU2MzE2NTU2MQ== max-sixty 5635139 2019-12-09T10:25:43Z 2019-12-09T10:25:43Z MEMBER

And test failure is unrelated (and think there's a PR to fix)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix pint integration tests 533580931
563165314 https://github.com/pydata/xarray/pull/3600#issuecomment-563165314 https://api.github.com/repos/pydata/xarray/issues/3600 MDEyOklzc3VlQ29tbWVudDU2MzE2NTMxNA== max-sixty 5635139 2019-12-09T10:25:13Z 2019-12-09T10:25:13Z MEMBER

Looks good! (as ever with these, I had a browse through and picked a couple of sections to look at more deeply, but didn't go through each line in detail)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix pint integration tests 533580931
562905492 https://github.com/pydata/xarray/pull/3600#issuecomment-562905492 https://api.github.com/repos/pydata/xarray/issues/3600 MDEyOklzc3VlQ29tbWVudDU2MjkwNTQ5Mg== jthielen 3460034 2019-12-08T02:15:04Z 2019-12-08T02:15:04Z CONTRIBUTOR

cumprod fails using xarray's structures (works fine with Quantity), so the xfail is still necessary. I also didn't isolate the dims from any tests other than align and I think we still need at least one more iteration to get full isolation (I'd like to leave that to a new PR, though -- maybe when we attempt to silence the UnitStrippedWarnings?).

Sounds like a good plan.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix pint integration tests 533580931
562905216 https://github.com/pydata/xarray/pull/3600#issuecomment-562905216 https://api.github.com/repos/pydata/xarray/issues/3600 MDEyOklzc3VlQ29tbWVudDU2MjkwNTIxNg== keewis 14808389 2019-12-08T02:10:09Z 2019-12-08T02:10:09Z MEMBER

I'm done with revisiting the tests so this is ready for review & merge.

@jthielen I think I applied most of the changes you requested. cumprod fails using xarray's structures (works fine with Quantity), so the xfail is still necessary. I also didn't isolate the dims from any tests other than align and I think we still need at least one more iteration to get full isolation (I'd like to leave that to a new PR, though -- maybe when we attempt to silence the UnitStrippedWarnings?).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix pint integration tests 533580931
562799809 https://github.com/pydata/xarray/pull/3600#issuecomment-562799809 https://api.github.com/repos/pydata/xarray/issues/3600 MDEyOklzc3VlQ29tbWVudDU2Mjc5OTgwOQ== max-sixty 5635139 2019-12-07T01:25:45Z 2019-12-07T01:25:45Z MEMBER

What do you mean with "flups"?

Sorry, that's probably not widely used! "flups"="follow-ups"

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix pint integration tests 533580931
562796384 https://github.com/pydata/xarray/pull/3600#issuecomment-562796384 https://api.github.com/repos/pydata/xarray/issues/3600 MDEyOklzc3VlQ29tbWVudDU2Mjc5NjM4NA== keewis 14808389 2019-12-07T01:00:11Z 2019-12-07T01:00:11Z MEMBER

I'd first like to go through the Dataset tests which probably won't need as much updates as the DataArray tests since I had more experience when I wrote them.

What do you mean with "flups"?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix pint integration tests 533580931
562795691 https://github.com/pydata/xarray/pull/3600#issuecomment-562795691 https://api.github.com/repos/pydata/xarray/issues/3600 MDEyOklzc3VlQ29tbWVudDU2Mjc5NTY5MQ== max-sixty 5635139 2019-12-07T00:55:05Z 2019-12-07T00:55:05Z MEMBER

Looks like a good set of improvements, thanks @keewis

Shall we merge this and do flups in another PR?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix pint integration tests 533580931
562369017 https://github.com/pydata/xarray/pull/3600#issuecomment-562369017 https://api.github.com/repos/pydata/xarray/issues/3600 MDEyOklzc3VlQ29tbWVudDU2MjM2OTAxNw== keewis 14808389 2019-12-05T23:46:52Z 2019-12-05T23:46:52Z MEMBER

np.rank is removed in one of the yet-to-be-pushed commits.

align/ etc.: not yet, but I can change the variants dict (replace original_unit with 1 if you want to play with it)

cumprod, matmul: sure, will do

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix pint integration tests 533580931
562348563 https://github.com/pydata/xarray/pull/3600#issuecomment-562348563 https://api.github.com/repos/pydata/xarray/issues/3600 MDEyOklzc3VlQ29tbWVudDU2MjM0ODU2Mw== jthielen 3460034 2019-12-05T22:32:44Z 2019-12-05T22:32:44Z CONTRIBUTOR

In general, this looks good!

After running through this, a couple thoughts did come to mind:

  • Do you have tests of align/combine_*/concat that have Quantity data but no Quantity coordinates? I think these could help isolate the coordinate/indexing issue from the any other operation-related issue.
  • Would you be able to alter the cumprod tests to test a dimensionless Quantity? np.cumprod is only supported (and only really makes sense) for dimensionless Quantities
  • Could you change the xfail reason for matrix multiplication to pint not supporting einsum? __matmul__ has been implemented in https://github.com/hgrecco/pint/pull/905, but xarray's __matmul__ appears to route through np.einsum.
  • Would it make sense to remove the np.rank test as discussed here: https://github.com/hgrecco/pint/pull/905#issuecomment-562109451?
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix pint integration tests 533580931

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);