home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 562905216

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3600#issuecomment-562905216 https://api.github.com/repos/pydata/xarray/issues/3600 562905216 MDEyOklzc3VlQ29tbWVudDU2MjkwNTIxNg== 14808389 2019-12-08T02:10:09Z 2019-12-08T02:10:09Z MEMBER

I'm done with revisiting the tests so this is ready for review & merge.

@jthielen I think I applied most of the changes you requested. cumprod fails using xarray's structures (works fine with Quantity), so the xfail is still necessary. I also didn't isolate the dims from any tests other than align and I think we still need at least one more iteration to get full isolation (I'd like to leave that to a new PR, though -- maybe when we attempt to silence the UnitStrippedWarnings?).

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  533580931
Powered by Datasette · Queries took 0.489ms · About: xarray-datasette