issue_comments

Table actions

5 rows where issue = 532940062 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • max-sixty · 5 ✖

issue 1

  • Add DataArray.pad, Dataset.pad, Variable.pad · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
601282600 https://github.com/pydata/xarray/pull/3596#issuecomment-601282600 https://api.github.com/repos/pydata/xarray/issues/3596 MDEyOklzc3VlQ29tbWVudDYwMTI4MjYwMA== max-sixty 5635139 2020-03-19T16:36:55Z 2020-03-19T16:36:55Z MEMBER

Thanks @mark-boer ! Must be one of the largest first contributions...

+1 re merge + experimental warning; maybe we should do this more often. Cheers @dcherian 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add DataArray.pad, Dataset.pad, Variable.pad 532940062
598730380 https://github.com/pydata/xarray/pull/3596#issuecomment-598730380 https://api.github.com/repos/pydata/xarray/issues/3596 MDEyOklzc3VlQ29tbWVudDU5ODczMDM4MA== max-sixty 5635139 2020-03-13T13:52:13Z 2020-03-13T13:52:13Z MEMBER

Agree!

We could add an "Experimental" label and then worry less about future changes

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add DataArray.pad, Dataset.pad, Variable.pad 532940062
596837204 https://github.com/pydata/xarray/pull/3596#issuecomment-596837204 https://api.github.com/repos/pydata/xarray/issues/3596 MDEyOklzc3VlQ29tbWVudDU5NjgzNzIwNA== max-sixty 5635139 2020-03-10T00:08:11Z 2020-03-10T00:08:11Z MEMBER

In some instances extrapolating all coords, can lead to some unwanted behaviour. Would you suggest we only interpolate the indexes?

How would we handle unsorted indexes?

How would we extrapolate all the different kind of indexes, like the MultiIndex or CategoricalIndex?

I agree; I can't see easy solutions to these. If there are evenly spaced indexes (e.g. dates, grids), then it's easy to know what to do. But there are plenty of times it's difficult, if not intractable.

One option to merge something useful without resolving these questions is to return Variables only and label this method experimental. I think this is immediately useful for the cases where these difficult questions don't need to be answered.

Of course if there are good answers to the questions, then even better!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add DataArray.pad, Dataset.pad, Variable.pad 532940062
595506745 https://github.com/pydata/xarray/pull/3596#issuecomment-595506745 https://api.github.com/repos/pydata/xarray/issues/3596 MDEyOklzc3VlQ29tbWVudDU5NTUwNjc0NQ== max-sixty 5635139 2020-03-06T00:04:03Z 2020-03-06T02:08:02Z MEMBER

I do agree it can be confusing, but it is not unique in xarray. Dataset.shift only shifts data_vars, bfill and ffill only fill data_vars, etc.

I agree, I wouldn't have expected coords to be included given existing behavior. People can switch coords <> data_vars as needed, so there's an escape hatch

Edit: But it's more awkward for indexes than non-index coords. The index becomes less useful with non-unique values, and generally indexes don't have nulls. I'm not sure what the other options would be: to some extent it's the intersection of pad with xarray's data model. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add DataArray.pad, Dataset.pad, Variable.pad 532940062
595244925 https://github.com/pydata/xarray/pull/3596#issuecomment-595244925 https://api.github.com/repos/pydata/xarray/issues/3596 MDEyOklzc3VlQ29tbWVudDU5NTI0NDkyNQ== max-sixty 5635139 2020-03-05T14:02:45Z 2020-03-05T14:02:45Z MEMBER

This looks excellent @mark-boer , thank you!

I will try and have a proper look through today (but don't wait for me)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add DataArray.pad, Dataset.pad, Variable.pad 532940062

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);