issues: 532940062

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
532940062 MDExOlB1bGxSZXF1ZXN0MzQ5MDk3Mzgz 3596 Add DataArray.pad, Dataset.pad, Variable.pad 12862013 closed 0     20 2019-12-04T21:18:41Z 2020-03-21T11:50:44Z 2020-03-19T14:41:50Z CONTRIBUTOR   0 pydata/xarray/pulls/3596

Hello all,

This is my first PR to a pydata project. This pull request is still very much a work in progress and I could really use your input on a couple of things.

  • [x] Closes #2605
  • [x] Tests added
  • [x] Passes black . && mypy . && flake8

  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API

  • I moved the custom dask pad method into dask_array_compat to ensure backwards compatability to Dask versions that do not have dask.pad yet. We could chose to drop this support if we wanted to.

  • I'm still in doubt about the function signature, numpy as dask use optional kwargs, but that kinda interferes with the **pad_width_kwargs. I chose the signature that I thought looked least awkward.
  • The default behaviour of pad with mode=constant pads with NaN's converting the array to float in the process. This goes against the default behaviour of numpy as dask.
  • How should the coordinates of a DataArray be padded? I chose default padding except for modes "edge", "reflect", "symmetric", "wrap".
  • How should we handle inconsistencies between numpy.pad and Dask.pad, it turns out there are a couple 5303

Dataset.pad is coming up.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/3596/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables