issue_comments

Table actions

24 rows where issue = 526273373 and user = 14808389 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

user 1

  • keewis · 24 ✖

issue 1

  • merge scipy19 docs · 24 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
557325251 https://github.com/pydata/xarray/pull/3557#issuecomment-557325251 https://api.github.com/repos/pydata/xarray/issues/3557 MDEyOklzc3VlQ29tbWVudDU1NzMyNTI1MQ== keewis 14808389 2019-11-21T23:54:15Z 2019-11-21T23:54:15Z MEMBER

I think we can merge after making sure RTD still builds?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   merge scipy19 docs 526273373
557323177 https://github.com/pydata/xarray/pull/3557#issuecomment-557323177 https://api.github.com/repos/pydata/xarray/issues/3557 MDEyOklzc3VlQ29tbWVudDU1NzMyMzE3Nw== keewis 14808389 2019-11-21T23:45:15Z 2019-11-21T23:45:15Z MEMBER

done

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   merge scipy19 docs 526273373
557316984 https://github.com/pydata/xarray/pull/3557#issuecomment-557316984 https://api.github.com/repos/pydata/xarray/issues/3557 MDEyOklzc3VlQ29tbWVudDU1NzMxNjk4NA== keewis 14808389 2019-11-21T23:21:55Z 2019-11-21T23:21:55Z MEMBER

how about - Switch doc examples to use nbsphinx and replace sphinx_gallery with notebook. (:pull:`3105`, :pull:`3106`, :pull:`3121`) By `Ryan Abernathey <https://github.com/rabernat>` - Added example notebook demonstrating the visualization of ERA5 GRIB data. (:pull:`3199`). By `Zach Bruick <https://github.com/zbruick>` and `Stephan Siemen <https://github.com/StephanSiemen>`

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   merge scipy19 docs 526273373
557314575 https://github.com/pydata/xarray/pull/3557#issuecomment-557314575 https://api.github.com/repos/pydata/xarray/issues/3557 MDEyOklzc3VlQ29tbWVudDU1NzMxNDU3NQ== keewis 14808389 2019-11-21T23:13:18Z 2019-11-21T23:13:27Z MEMBER

while we have an entry for #3116 the one for #3199 is missing (also, @rabernat, do you want an entry for switching to nbsphinx?)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   merge scipy19 docs 526273373
557313484 https://github.com/pydata/xarray/pull/3557#issuecomment-557313484 https://api.github.com/repos/pydata/xarray/issues/3557 MDEyOklzc3VlQ29tbWVudDU1NzMxMzQ4NA== keewis 14808389 2019-11-21T23:09:08Z 2019-11-21T23:09:08Z MEMBER

would that be documentation or enhancements?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   merge scipy19 docs 526273373
557311995 https://github.com/pydata/xarray/pull/3557#issuecomment-557311995 https://api.github.com/repos/pydata/xarray/issues/3557 MDEyOklzc3VlQ29tbWVudDU1NzMxMTk5NQ== keewis 14808389 2019-11-21T23:03:35Z 2019-11-21T23:03:35Z MEMBER

ah, maybe we should move the whats-new.rst entries?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   merge scipy19 docs 526273373
557309528 https://github.com/pydata/xarray/pull/3557#issuecomment-557309528 https://api.github.com/repos/pydata/xarray/issues/3557 MDEyOklzc3VlQ29tbWVudDU1NzMwOTUyOA== keewis 14808389 2019-11-21T22:55:39Z 2019-11-21T22:55:39Z MEMBER

@dcherian, I'd merge into master and then cherry-pick into stable?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   merge scipy19 docs 526273373
557309056 https://github.com/pydata/xarray/pull/3557#issuecomment-557309056 https://api.github.com/repos/pydata/xarray/issues/3557 MDEyOklzc3VlQ29tbWVudDU1NzMwOTA1Ng== keewis 14808389 2019-11-21T22:54:16Z 2019-11-21T22:54:16Z MEMBER

yeah, should we merge to stable we should probably rebase first

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   merge scipy19 docs 526273373
557307923 https://github.com/pydata/xarray/pull/3557#issuecomment-557307923 https://api.github.com/repos/pydata/xarray/issues/3557 MDEyOklzc3VlQ29tbWVudDU1NzMwNzkyMw== keewis 14808389 2019-11-21T22:50:33Z 2019-11-21T22:50:33Z MEMBER

one thing that might be done in a future PR is enabling the HTML reprs?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   merge scipy19 docs 526273373
557305287 https://github.com/pydata/xarray/pull/3557#issuecomment-557305287 https://api.github.com/repos/pydata/xarray/issues/3557 MDEyOklzc3VlQ29tbWVudDU1NzMwNTI4Nw== keewis 14808389 2019-11-21T22:41:21Z 2019-11-21T22:41:21Z MEMBER

I would think so, but I think we can fix anything that pops up later in new PRs.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   merge scipy19 docs 526273373
557293832 https://github.com/pydata/xarray/pull/3557#issuecomment-557293832 https://api.github.com/repos/pydata/xarray/issues/3557 MDEyOklzc3VlQ29tbWVudDU1NzI5MzgzMg== keewis 14808389 2019-11-21T22:05:36Z 2019-11-21T22:09:16Z MEMBER

okay. How about using Parsing the geocoordinates of rasterio or Parsing the rasterio geocoordinates?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   merge scipy19 docs 526273373
557293969 https://github.com/pydata/xarray/pull/3557#issuecomment-557293969 https://api.github.com/repos/pydata/xarray/issues/3557 MDEyOklzc3VlQ29tbWVudDU1NzI5Mzk2OQ== keewis 14808389 2019-11-21T22:06:04Z 2019-11-21T22:06:04Z MEMBER

oh, and is there a reason why we merge into stable instead of master?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   merge scipy19 docs 526273373
557285500 https://github.com/pydata/xarray/pull/3557#issuecomment-557285500 https://api.github.com/repos/pydata/xarray/issues/3557 MDEyOklzc3VlQ29tbWVudDU1NzI4NTUwMA== keewis 14808389 2019-11-21T21:43:33Z 2019-11-21T21:43:33Z MEMBER

the shadowing was avoided by using pip for installing cfgrib (otherwise it would have pulled a packaged version of xarray). Anyways, the build seems to have been successfully completed

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   merge scipy19 docs 526273373
557278022 https://github.com/pydata/xarray/pull/3557#issuecomment-557278022 https://api.github.com/repos/pydata/xarray/issues/3557 MDEyOklzc3VlQ29tbWVudDU1NzI3ODAyMg== keewis 14808389 2019-11-21T21:23:39Z 2019-11-21T21:23:39Z MEMBER

also, there is one issue with the labels: this /examples/visualization_gallery.ipynb#parsing-rasterio%u2019s-geocoordinates does not work (because of the unicode character I think).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   merge scipy19 docs 526273373
557276254 https://github.com/pydata/xarray/pull/3557#issuecomment-557276254 https://api.github.com/repos/pydata/xarray/issues/3557 MDEyOklzc3VlQ29tbWVudDU1NzI3NjI1NA== keewis 14808389 2019-11-21T21:18:53Z 2019-11-21T21:21:05Z MEMBER

I added the changes from #3464 to the notebook. @rabernat, do you have the time to check whether the cherry-picks were applied correctly?

@dcherian, do you think you can try out this branch on the official RTD setup that (apparently) has more resources? I don't think I can make my setup work without a lot of effort.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   merge scipy19 docs 526273373
557208666 https://github.com/pydata/xarray/pull/3557#issuecomment-557208666 https://api.github.com/repos/pydata/xarray/issues/3557 MDEyOklzc3VlQ29tbWVudDU1NzIwODY2Ng== keewis 14808389 2019-11-21T18:16:28Z 2019-11-21T18:16:28Z MEMBER

oh, and we have some warnings regarding missing document labels. Is there a way to reference labels in notebooks?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   merge scipy19 docs 526273373
557205607 https://github.com/pydata/xarray/pull/3557#issuecomment-557205607 https://api.github.com/repos/pydata/xarray/issues/3557 MDEyOklzc3VlQ29tbWVudDU1NzIwNTYwNw== keewis 14808389 2019-11-21T18:08:24Z 2019-11-21T18:08:24Z MEMBER

now that CI passes we only need to get the readthedocs build to work (and maybe re-apply #3464?).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   merge scipy19 docs 526273373
557181868 https://github.com/pydata/xarray/pull/3557#issuecomment-557181868 https://api.github.com/repos/pydata/xarray/issues/3557 MDEyOklzc3VlQ29tbWVudDU1NzE4MTg2OA== keewis 14808389 2019-11-21T17:09:07Z 2019-11-21T17:09:07Z MEMBER

iris from github would work, but cartopy has no wheels, so installing using pip fails. I'll stop investigating this for now and try to make CI pass.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   merge scipy19 docs 526273373
557154643 https://github.com/pydata/xarray/pull/3557#issuecomment-557154643 https://api.github.com/repos/pydata/xarray/issues/3557 MDEyOklzc3VlQ29tbWVudDU1NzE1NDY0Mw== keewis 14808389 2019-11-21T16:08:53Z 2019-11-21T16:26:32Z MEMBER

I'm currently trying to move everything except python and iris into the pip section, let's see what kind of memory usage that gives us.

Edit: that almost worked, it failed in the execution state. I'll try to install iris from github.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   merge scipy19 docs 526273373
557148330 https://github.com/pydata/xarray/pull/3557#issuecomment-557148330 https://api.github.com/repos/pydata/xarray/issues/3557 MDEyOklzc3VlQ29tbWVudDU1NzE0ODMzMA== keewis 14808389 2019-11-21T15:55:26Z 2019-11-21T15:55:26Z MEMBER

probably, but the only issue I found is this: https://pypi.org/project/iris/, which means iris is only available on conda-forge?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   merge scipy19 docs 526273373
557143391 https://github.com/pydata/xarray/pull/3557#issuecomment-557143391 https://api.github.com/repos/pydata/xarray/issues/3557 MDEyOklzc3VlQ29tbWVudDU1NzE0MzM5MQ== keewis 14808389 2019-11-21T15:45:22Z 2019-11-21T15:45:22Z MEMBER

and now I ran into the shadowing issue we had in #3199. I think the culprit is cfgrib which uses extras_require to pull in xarray. Is there any way to tell conda not to use that? We could also try to pull it using pip, since that works (at least for me) and bypasses the download of the packaged xarray.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   merge scipy19 docs 526273373
557111157 https://github.com/pydata/xarray/pull/3557#issuecomment-557111157 https://api.github.com/repos/pydata/xarray/issues/3557 MDEyOklzc3VlQ29tbWVudDU1NzExMTE1Nw== keewis 14808389 2019-11-21T14:33:07Z 2019-11-21T14:33:07Z MEMBER

okay, now the cherry-picking is done and the number of touched files is down to a more reasonable 14, though I dropped the non-PR commits. I'm not sure which of these was really necessary, but I guess that's something that we will notice once we try to get CI and readthedocs to work?

The original branch is still available for comparison on scipy19-docs

@dcherian (or anyone else who knows a bit more about RTD than me), can you help me fix the readthedocs builds? I can't test anything as long as the environment creation fails.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   merge scipy19 docs 526273373
556713265 https://github.com/pydata/xarray/pull/3557#issuecomment-556713265 https://api.github.com/repos/pydata/xarray/issues/3557 MDEyOklzc3VlQ29tbWVudDU1NjcxMzI2NQ== keewis 14808389 2019-11-21T00:58:46Z 2019-11-21T00:58:46Z MEMBER

it looks like it would be easier to do this by rebasing / cherry-picking onto master: there would not be as many conflicts as using merge would have (look at the list: 146 changed files). I'll cherry-pick and force push afterwards.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   merge scipy19 docs 526273373
556552883 https://github.com/pydata/xarray/pull/3557#issuecomment-556552883 https://api.github.com/repos/pydata/xarray/issues/3557 MDEyOklzc3VlQ29tbWVudDU1NjU1Mjg4Mw== keewis 14808389 2019-11-20T23:48:01Z 2019-11-20T23:48:01Z MEMBER

something that could in the long run reduce the memory usage might be conda-metachannel (blog post), but I think the integration into conda is in its early stages?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   merge scipy19 docs 526273373

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);