issue_comments

Table actions

5 rows where issue = 525903846 and user = 4179064 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • xylar · 5 ✖

issue 1

  • Dataset.drop() no longer works with a set as an argument · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
556111055 https://github.com/pydata/xarray/issues/3552#issuecomment-556111055 https://api.github.com/repos/pydata/xarray/issues/3552 MDEyOklzc3VlQ29tbWVudDU1NjExMTA1NQ== xylar 4179064 2019-11-20T17:05:33Z 2019-11-20T17:05:33Z NONE

Ah, thanks very much! I'll switch to using that syntax instead.

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset.drop() no longer works with a set as an argument 525903846
556096924 https://github.com/pydata/xarray/issues/3552#issuecomment-556096924 https://api.github.com/repos/pydata/xarray/issues/3552 MDEyOklzc3VlQ29tbWVudDU1NjA5NjkyNA== xylar 4179064 2019-11-20T16:53:40Z 2019-11-20T16:53:40Z NONE

I apologize for this slight tangent but it's related to why we use sets in drop(). Is there a good way in xarray to only keep a list of variables? Our approach is to create a set of all variable and subtract from it a set of variables we want to keep and to drop the resulting set of variables we don't want to keep. But it's hard for me to imagine others don't also need this functionality.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset.drop() no longer works with a set as an argument 525903846
556095452 https://github.com/pydata/xarray/issues/3552#issuecomment-556095452 https://api.github.com/repos/pydata/xarray/issues/3552 MDEyOklzc3VlQ29tbWVudDU1NjA5NTQ1Mg== xylar 4179064 2019-11-20T16:50:15Z 2019-11-20T16:50:15Z NONE

Additionally, I think we have a documentation bug: I can't reach the documentation on drop.

Yes, I noticed that, too. I assumed it wasn't being documented anymore because it was considered deprecated. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset.drop() no longer works with a set as an argument 525903846
556091171 https://github.com/pydata/xarray/issues/3552#issuecomment-556091171 https://api.github.com/repos/pydata/xarray/issues/3552 MDEyOklzc3VlQ29tbWVudDU1NjA5MTE3MQ== xylar 4179064 2019-11-20T16:41:09Z 2019-11-20T16:43:01Z NONE

@dcherian - are you suggesting that @xylar change his downstream code to use drop_vars instead? drop_vars has been deprecated. I don't think that's the right response here.

I'm confused. In 0.14.1, drop_vars seems to have just been introduced and drop seems to have been dropped.

How about drop_vars instead?

Yes, I switched to drop_vars but first I had to make a new build of my conda package that constrains the dependency xarray <0.14.0 because it's broken with 0.14.1. So that's why I'm concerned. I have to do a new release before this fix propagates to my users.

So @rabernat and @dcherian, please clarify if I should be switching to drop_vars or if I am going to run into issues yet again if I do so?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset.drop() no longer works with a set as an argument 525903846
556077504 https://github.com/pydata/xarray/issues/3552#issuecomment-556077504 https://api.github.com/repos/pydata/xarray/issues/3552 MDEyOklzc3VlQ29tbWVudDU1NjA3NzUwNA== xylar 4179064 2019-11-20T16:10:54Z 2019-11-20T16:11:13Z NONE

I believe a set() object should be a valid labels argument according to the documentation of drop(): http://xarray.pydata.org/en/v0.14.0/generated/xarray.Dataset.drop.html#xarray.Dataset.drop

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset.drop() no longer works with a set as an argument 525903846

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);