home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 556091171

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/3552#issuecomment-556091171 https://api.github.com/repos/pydata/xarray/issues/3552 556091171 MDEyOklzc3VlQ29tbWVudDU1NjA5MTE3MQ== 4179064 2019-11-20T16:41:09Z 2019-11-20T16:43:01Z NONE

@dcherian - are you suggesting that @xylar change his downstream code to use drop_vars instead? drop_vars has been deprecated. I don't think that's the right response here.

I'm confused. In 0.14.1, drop_vars seems to have just been introduced and drop seems to have been dropped.

How about drop_vars instead?

Yes, I switched to drop_vars but first I had to make a new build of my conda package that constrains the dependency xarray <0.14.0 because it's broken with 0.14.1. So that's why I'm concerned. I have to do a new release before this fix propagates to my users.

So @rabernat and @dcherian, please clarify if I should be switching to drop_vars or if I am going to run into issues yet again if I do so?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  525903846
Powered by Datasette · Queries took 77.65ms · About: xarray-datasette