issue_comments

Table actions

3 rows where issue = 512564022 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • max-sixty · 3 ✖

issue 1

  • tests for datasets with units · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
552064856 https://github.com/pydata/xarray/pull/3447#issuecomment-552064856 https://api.github.com/repos/pydata/xarray/issues/3447 MDEyOklzc3VlQ29tbWVudDU1MjA2NDg1Ng== max-sixty 5635139 2019-11-09T04:21:23Z 2019-11-09T04:21:23Z MEMBER

Great @keewis . As above, I haven't looked through all (1750!!) LoC, but looks good on the code I have. Let me / us know if there's anything you want us to look into more.

Thank you v much!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   tests for datasets with units 512564022
548128979 https://github.com/pydata/xarray/pull/3447#issuecomment-548128979 https://api.github.com/repos/pydata/xarray/issues/3447 MDEyOklzc3VlQ29tbWVudDU0ODEyODk3OQ== max-sixty 5635139 2019-10-30T21:53:52Z 2019-10-30T21:53:52Z MEMBER

I think they at least partially test the same code: if two DataArray objects that get passed to the Dataset constructor as data variables have the same dimensions / coordinates, they get merged. I think that happens even if the values of the dims / coords are equal.

Ah great, because merge happens in a dataset's init, yes. Let's keep both tests though

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   tests for datasets with units 512564022
548110891 https://github.com/pydata/xarray/pull/3447#issuecomment-548110891 https://api.github.com/repos/pydata/xarray/issues/3447 MDEyOklzc3VlQ29tbWVudDU0ODExMDg5MQ== max-sixty 5635139 2019-10-30T21:02:08Z 2019-10-30T21:02:08Z MEMBER

Looks really good. I spent 20 mins looking through and looks very thorough. I didn't read through every function. Let me know if there are any other ones you want someone to look through

I am especially interested in comments on Dataset.__init__ and Dataset.test_merge, since at the moment they seem to test the same code.

I had a good look through these. (though I didn't fully understand re 'test the same code', they seem to test the relevant init / merge functions?)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   tests for datasets with units 512564022

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);