issue_comments: 548110891

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3447#issuecomment-548110891 https://api.github.com/repos/pydata/xarray/issues/3447 548110891 MDEyOklzc3VlQ29tbWVudDU0ODExMDg5MQ== 5635139 2019-10-30T21:02:08Z 2019-10-30T21:02:08Z MEMBER

Looks really good. I spent 20 mins looking through and looks very thorough. I didn't read through every function. Let me know if there are any other ones you want someone to look through

I am especially interested in comments on Dataset.__init__ and Dataset.test_merge, since at the moment they seem to test the same code.

I had a good look through these. (though I didn't fully understand re 'test the same code', they seem to test the relevant init / merge functions?)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   512564022