issue_comments

Table actions

3 rows where issue = 510892578 and user = 167802 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • mraspaud · 3 ✖

issue 1

  • Attributes are dropped after `clip` even if `keep_attrs` is True · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
545829813 https://github.com/pydata/xarray/issues/3433#issuecomment-545829813 https://api.github.com/repos/pydata/xarray/issues/3433 MDEyOklzc3VlQ29tbWVudDU0NTgyOTgxMw== mraspaud 167802 2019-10-24T09:23:14Z 2019-10-24T09:23:14Z CONTRIBUTOR

Ok, then I probably won't have the time to dig into this for now, sorry. If someone else with better knowledge of the code can work on this it would probably be for the best.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Attributes are dropped after `clip` even if `keep_attrs` is True 510892578
545303756 https://github.com/pydata/xarray/issues/3433#issuecomment-545303756 https://api.github.com/repos/pydata/xarray/issues/3433 MDEyOklzc3VlQ29tbWVudDU0NTMwMzc1Ng== mraspaud 167802 2019-10-23T07:12:22Z 2019-10-23T07:13:22Z CONTRIBUTOR

ooh, maybe I answered too fast. I hadn't really looked at the code yet... but let's see: if I understand correctly, in the function you cited, the functions get wrapped and include in the current cls. So I would need to fix the wrapper itself (_func_slash_method_wrapper) so that the attrs get copied and applied to the resulting array (if keep_attrs is True that is). However, do we have a guarantee that the wrapped functions are actually returning something that can have a .attrs ?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Attributes are dropped after `clip` even if `keep_attrs` is True 510892578
545295063 https://github.com/pydata/xarray/issues/3433#issuecomment-545295063 https://api.github.com/repos/pydata/xarray/issues/3433 MDEyOklzc3VlQ29tbWVudDU0NTI5NTA2Mw== mraspaud 167802 2019-10-23T06:47:00Z 2019-10-23T06:47:00Z CONTRIBUTOR

Sure! What do you reckon the default should be ? False for backwards compatibility ?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Attributes are dropped after `clip` even if `keep_attrs` is True 510892578

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);