issue_comments: 545303756

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/3433#issuecomment-545303756 https://api.github.com/repos/pydata/xarray/issues/3433 545303756 MDEyOklzc3VlQ29tbWVudDU0NTMwMzc1Ng== 167802 2019-10-23T07:12:22Z 2019-10-23T07:13:22Z CONTRIBUTOR

ooh, maybe I answered too fast. I hadn't really looked at the code yet... but let's see: if I understand correctly, in the function you cited, the functions get wrapped and include in the current cls. So I would need to fix the wrapper itself (_func_slash_method_wrapper) so that the attrs get copied and applied to the resulting array (if keep_attrs is True that is). However, do we have a guarantee that the wrapped functions are actually returning something that can have a .attrs ?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   510892578