issue_comments

Table actions

7 rows where issue = 509421390 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 2

issue 1

  • fix #3141 add cumsum to DatasetGroupBy · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1111474046 https://github.com/pydata/xarray/pull/3417#issuecomment-1111474046 https://api.github.com/repos/pydata/xarray/issues/3417 IC_kwDOAMm_X85CP79- max-sixty 5635139 2022-04-27T20:54:24Z 2022-04-27T20:54:24Z MEMBER

Thanks a lot @dcherian ! 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix #3141 add cumsum to DatasetGroupBy 509421390
1111132978 https://github.com/pydata/xarray/pull/3417#issuecomment-1111132978 https://api.github.com/repos/pydata/xarray/issues/3417 IC_kwDOAMm_X85COosy dcherian 2448579 2022-04-27T15:20:27Z 2022-04-27T15:30:08Z MEMBER

I opened #6525 preserving commit authorship. Does that look right to everyone? I could force-push here but was afraid of losing the author info.

That PR doesn't actually work, it's not clear to me why.

EDIT: OK it works now, but we have the same error about losing an index

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix #3141 add cumsum to DatasetGroupBy 509421390
1111119467 https://github.com/pydata/xarray/pull/3417#issuecomment-1111119467 https://api.github.com/repos/pydata/xarray/issues/3417 IC_kwDOAMm_X85COlZr dcherian 2448579 2022-04-27T15:08:17Z 2022-04-27T15:08:17Z MEMBER

It doesn't at the moment. Writing the dask version will be fun :).

We can always add groupby().cumsum and use the "old" codepath like we do for median.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix #3141 add cumsum to DatasetGroupBy 509421390
1110601275 https://github.com/pydata/xarray/pull/3417#issuecomment-1110601275 https://api.github.com/repos/pydata/xarray/issues/3417 IC_kwDOAMm_X85CMm47 max-sixty 5635139 2022-04-27T06:38:05Z 2022-04-27T06:38:05Z MEMBER

Aren't we soon going to let flox handle this once #5734 is merged? numpy_groupies supports cumsum at least so it might be possible to support it in flox as well.

Ah, great, if flox supports cumsum then that is indeed ideal.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix #3141 add cumsum to DatasetGroupBy 509421390
1110590762 https://github.com/pydata/xarray/pull/3417#issuecomment-1110590762 https://api.github.com/repos/pydata/xarray/issues/3417 IC_kwDOAMm_X85CMkUq Illviljan 14371165 2022-04-27T06:23:02Z 2022-04-27T06:23:02Z MEMBER

Aren't we soon going to let flox handle this once #5734 is merged? numpy_groupies supports cumsum at least so it might be possible to support it in flox as well.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix #3141 add cumsum to DatasetGroupBy 509421390
1110061422 https://github.com/pydata/xarray/pull/3417#issuecomment-1110061422 https://api.github.com/repos/pydata/xarray/issues/3417 IC_kwDOAMm_X85CKjFu max-sixty 5635139 2022-04-26T17:25:29Z 2022-04-26T17:25:29Z MEMBER

I'm very sorry this didn't get attention — it was a good PR and it's bad of us to drop something from a first-time contributor.

It was surprising that it promoted the group_id variable to a data_var from a coord — I think that's probably a mistake. So if we could resolve that — or show that it would have other adverse impacts — we could merge this.

The good news is that we simplified how methods are supplied to the GroupBy objects — the bad news is that it requires a small rewrite of the code now; though not the tests, which are the majority of this code.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix #3141 add cumsum to DatasetGroupBy 509421390
1109755369 https://github.com/pydata/xarray/pull/3417#issuecomment-1109755369 https://api.github.com/repos/pydata/xarray/issues/3417 IC_kwDOAMm_X85CJYXp pgierz 2444231 2022-04-26T12:49:13Z 2022-04-26T12:49:13Z NONE

Any progress on this one? I would like to use this functionality. I have a workaround for right now, but it would be nice to do it "correctly"

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix #3141 add cumsum to DatasetGroupBy 509421390

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);