issue_comments: 1110061422

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3417#issuecomment-1110061422 https://api.github.com/repos/pydata/xarray/issues/3417 1110061422 IC_kwDOAMm_X85CKjFu 5635139 2022-04-26T17:25:29Z 2022-04-26T17:25:29Z MEMBER

I'm very sorry this didn't get attention — it was a good PR and it's bad of us to drop something from a first-time contributor.

It was surprising that it promoted the group_id variable to a data_var from a coord — I think that's probably a mistake. So if we could resolve that — or show that it would have other adverse impacts — we could merge this.

The good news is that we simplified how methods are supplied to the GroupBy objects — the bad news is that it requires a small rewrite of the code now; though not the tests, which are the majority of this code.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   509421390