issue_comments

Table actions

2 rows where issue = 505409694 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • shoyer · 2 ✖

issue 1

  • OrderedDict --> dict, some python3.5 cleanup too · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
544613757 https://github.com/pydata/xarray/pull/3389#issuecomment-544613757 https://api.github.com/repos/pydata/xarray/issues/3389 MDEyOklzc3VlQ29tbWVudDU0NDYxMzc1Nw== shoyer 1217238 2019-10-21T17:10:21Z 2019-10-21T17:10:21Z MEMBER

Pypy already has ordered dicts on all versions of Python it supports. So technically you're right, but in practice this holds for every existing implementation of Python that could run xarray. Unless there's another one that I'm missing?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   OrderedDict --> dict, some python3.5 cleanup too 505409694
540705544 https://github.com/pydata/xarray/pull/3389#issuecomment-540705544 https://api.github.com/repos/pydata/xarray/issues/3389 MDEyOklzc3VlQ29tbWVudDU0MDcwNTU0NA== shoyer 1217238 2019-10-10T18:08:34Z 2019-10-10T18:08:34Z MEMBER

I'm also not sure where/how to do @shoyer's comment:

Should we also make assign and assign_coords no longer sort their arguments? We can do that now that dictionary are always ordered

I think this usage of SortedKeysDict could just become dict: https://github.com/pydata/xarray/blob/a4c0210d6cbc6d28859ac21a3af8808e2660b0c0/xarray/core/common.py#L384

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   OrderedDict --> dict, some python3.5 cleanup too 505409694

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);