issue_comments

Table actions

9 rows where issue = 505409694 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 4

author_association 2

issue 1

  • OrderedDict --> dict, some python3.5 cleanup too · 9 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
545301953 https://github.com/pydata/xarray/pull/3389#issuecomment-545301953 https://api.github.com/repos/pydata/xarray/issues/3389 MDEyOklzc3VlQ29tbWVudDU0NTMwMTk1Mw== ttung 280924 2019-10-23T07:07:10Z 2019-10-23T07:07:10Z CONTRIBUTOR

No idea if there are any other ones; you're probably right.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   OrderedDict --> dict, some python3.5 cleanup too 505409694
544613757 https://github.com/pydata/xarray/pull/3389#issuecomment-544613757 https://api.github.com/repos/pydata/xarray/issues/3389 MDEyOklzc3VlQ29tbWVudDU0NDYxMzc1Nw== shoyer 1217238 2019-10-21T17:10:21Z 2019-10-21T17:10:21Z MEMBER

Pypy already has ordered dicts on all versions of Python it supports. So technically you're right, but in practice this holds for every existing implementation of Python that could run xarray. Unless there's another one that I'm missing?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   OrderedDict --> dict, some python3.5 cleanup too 505409694
544606329 https://github.com/pydata/xarray/pull/3389#issuecomment-544606329 https://api.github.com/repos/pydata/xarray/issues/3389 MDEyOklzc3VlQ29tbWVudDU0NDYwNjMyOQ== ttung 280924 2019-10-21T16:52:32Z 2019-10-21T16:52:32Z CONTRIBUTOR

FYI, python 3.6 does not guarantee that dicts are ordered. CPython 3.6 happens to have that implementation but pypy, for instance, is not required to follow that. Python 3.7, however, mandates that dicts are ordered.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   OrderedDict --> dict, some python3.5 cleanup too 505409694
541363303 https://github.com/pydata/xarray/pull/3389#issuecomment-541363303 https://api.github.com/repos/pydata/xarray/issues/3389 MDEyOklzc3VlQ29tbWVudDU0MTM2MzMwMw== jhamman 2443309 2019-10-12T21:34:05Z 2019-10-12T21:34:05Z MEMBER

Thanks @crusaderky - fixes to the __init__ methods look good!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   OrderedDict --> dict, some python3.5 cleanup too 505409694
541344297 https://github.com/pydata/xarray/pull/3389#issuecomment-541344297 https://api.github.com/repos/pydata/xarray/issues/3389 MDEyOklzc3VlQ29tbWVudDU0MTM0NDI5Nw== crusaderky 6213168 2019-10-12T17:16:45Z 2019-10-12T17:16:45Z MEMBER

@jhamman I did a polish pass. Please review (particularly the substantial changes to DataArray.__init__ and Dataset.__init__)

Once you're happy, you can merge

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   OrderedDict --> dict, some python3.5 cleanup too 505409694
541318062 https://github.com/pydata/xarray/pull/3389#issuecomment-541318062 https://api.github.com/repos/pydata/xarray/issues/3389 MDEyOklzc3VlQ29tbWVudDU0MTMxODA2Mg== crusaderky 6213168 2019-10-12T11:57:30Z 2019-10-12T11:57:30Z MEMBER

I'll try to go through it later today

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   OrderedDict --> dict, some python3.5 cleanup too 505409694
540744298 https://github.com/pydata/xarray/pull/3389#issuecomment-540744298 https://api.github.com/repos/pydata/xarray/issues/3389 MDEyOklzc3VlQ29tbWVudDU0MDc0NDI5OA== jhamman 2443309 2019-10-10T19:29:18Z 2019-10-10T19:29:18Z MEMBER

All green here. @crusaderky - I'd appreciate it if you could give this a quick look over.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   OrderedDict --> dict, some python3.5 cleanup too 505409694
540705544 https://github.com/pydata/xarray/pull/3389#issuecomment-540705544 https://api.github.com/repos/pydata/xarray/issues/3389 MDEyOklzc3VlQ29tbWVudDU0MDcwNTU0NA== shoyer 1217238 2019-10-10T18:08:34Z 2019-10-10T18:08:34Z MEMBER

I'm also not sure where/how to do @shoyer's comment:

Should we also make assign and assign_coords no longer sort their arguments? We can do that now that dictionary are always ordered

I think this usage of SortedKeysDict could just become dict: https://github.com/pydata/xarray/blob/a4c0210d6cbc6d28859ac21a3af8808e2660b0c0/xarray/core/common.py#L384

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   OrderedDict --> dict, some python3.5 cleanup too 505409694
540701458 https://github.com/pydata/xarray/pull/3389#issuecomment-540701458 https://api.github.com/repos/pydata/xarray/issues/3389 MDEyOklzc3VlQ29tbWVudDU0MDcwMTQ1OA== jhamman 2443309 2019-10-10T17:58:19Z 2019-10-10T17:58:19Z MEMBER

I'm also not sure where/how to do @shoyer's comment:

Should we also make assign and assign_coords no longer sort their arguments? We can do that now that dictionary are always ordered

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   OrderedDict --> dict, some python3.5 cleanup too 505409694

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);