issue_comments

Table actions

10 rows where issue = 495920497 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • `sel` fails confusingly or silently when a dimension name matches an optional argument · 10 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
533713303 https://github.com/pydata/xarray/issues/3324#issuecomment-533713303 https://api.github.com/repos/pydata/xarray/issues/3324 MDEyOklzc3VlQ29tbWVudDUzMzcxMzMwMw== dcherian 2448579 2019-09-20T21:23:17Z 2019-09-20T21:23:17Z MEMBER

Yes add another kwarg

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `sel` fails confusingly or silently when a dimension name matches an optional argument 495920497
533693878 https://github.com/pydata/xarray/issues/3324#issuecomment-533693878 https://api.github.com/repos/pydata/xarray/issues/3324 MDEyOklzc3VlQ29tbWVudDUzMzY5Mzg3OA== gwgundersen 2818208 2019-09-20T20:13:07Z 2019-09-20T20:13:07Z CONTRIBUTOR

This could be an addition to the either_dict_or_kwargs helper function.

Currently, either_dict_or_kwargs doesn't have access to the DataArray instance's dims or the function's keyword arguments; are you suggesting that either_dict_or_kwargs be modified to take these? I do like this approach. Otherwise, I'd have to add a second utility function check everywhere either_dict_or_kwargs is used, and it'd be easy to forget going forward.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `sel` fails confusingly or silently when a dimension name matches an optional argument 495920497
533678033 https://github.com/pydata/xarray/issues/3324#issuecomment-533678033 https://api.github.com/repos/pydata/xarray/issues/3324 MDEyOklzc3VlQ29tbWVudDUzMzY3ODAzMw== shoyer 1217238 2019-09-20T19:16:46Z 2019-09-20T19:16:46Z MEMBER

This could be an addition to the either_dict_or_kwargs helper function: https://github.com/pydata/xarray/blob/df259331c5b66088f67738338e0b1b3f940e09c2/xarray/core/utils.py#L248

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `sel` fails confusingly or silently when a dimension name matches an optional argument 495920497
533677642 https://github.com/pydata/xarray/issues/3324#issuecomment-533677642 https://api.github.com/repos/pydata/xarray/issues/3324 MDEyOklzc3VlQ29tbWVudDUzMzY3NzY0Mg== shoyer 1217238 2019-09-20T19:15:28Z 2019-09-20T19:15:28Z MEMBER

What if I create a PR with a function in utils that takes an array and a list of keyword arguments, and warns the user if the array has any of the keyword arguments as dimensions. The warning can suggest using a dict.

This sounds great to me!

I have also been bitten by this issue, particularly with the same dimension name method.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `sel` fails confusingly or silently when a dimension name matches an optional argument 495920497
533603511 https://github.com/pydata/xarray/issues/3324#issuecomment-533603511 https://api.github.com/repos/pydata/xarray/issues/3324 MDEyOklzc3VlQ29tbWVudDUzMzYwMzUxMQ== max-sixty 5635139 2019-09-20T15:34:18Z 2019-09-20T15:34:18Z MEMBER

Yes I agree, on reflection

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `sel` fails confusingly or silently when a dimension name matches an optional argument 495920497
533592639 https://github.com/pydata/xarray/issues/3324#issuecomment-533592639 https://api.github.com/repos/pydata/xarray/issues/3324 MDEyOklzc3VlQ29tbWVudDUzMzU5MjYzOQ== dcherian 2448579 2019-09-20T15:08:36Z 2019-09-20T15:08:36Z MEMBER

Yes. fat fingers on mobile :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `sel` fails confusingly or silently when a dimension name matches an optional argument 495920497
533591239 https://github.com/pydata/xarray/issues/3324#issuecomment-533591239 https://api.github.com/repos/pydata/xarray/issues/3324 MDEyOklzc3VlQ29tbWVudDUzMzU5MTIzOQ== max-sixty 5635139 2019-09-20T15:04:51Z 2019-09-20T15:04:51Z MEMBER

+1. Though I prefer raising a more informative over raising a warning.

Raising an error?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `sel` fails confusingly or silently when a dimension name matches an optional argument 495920497
533531201 https://github.com/pydata/xarray/issues/3324#issuecomment-533531201 https://api.github.com/repos/pydata/xarray/issues/3324 MDEyOklzc3VlQ29tbWVudDUzMzUzMTIwMQ== dcherian 2448579 2019-09-20T12:24:04Z 2019-09-20T12:24:04Z MEMBER

+1. Though I prefer raising a more informative over raising a warning.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `sel` fails confusingly or silently when a dimension name matches an optional argument 495920497
533515745 https://github.com/pydata/xarray/issues/3324#issuecomment-533515745 https://api.github.com/repos/pydata/xarray/issues/3324 MDEyOklzc3VlQ29tbWVudDUzMzUxNTc0NQ== gwgundersen 2818208 2019-09-20T11:28:48Z 2019-09-20T11:28:48Z CONTRIBUTOR

What if I create a PR with a function in utils that takes an array and a list of keyword arguments, and warns the user if the array has any of the keyword arguments as dimensions. The warning can suggest using a dict.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `sel` fails confusingly or silently when a dimension name matches an optional argument 495920497
533248467 https://github.com/pydata/xarray/issues/3324#issuecomment-533248467 https://api.github.com/repos/pydata/xarray/issues/3324 MDEyOklzc3VlQ29tbWVudDUzMzI0ODQ2Nw== max-sixty 5635139 2019-09-19T18:15:36Z 2019-09-19T18:15:36Z MEMBER

Yes, agree this isn't ideal. One of the great qualities of xarray is the code we write in exploration also works in production, and this behavior violates some of that. I'd vote for a warning as getting some of the way to a solution

FWIW passing a dict to these methods will work, if you want complete dependability

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `sel` fails confusingly or silently when a dimension name matches an optional argument 495920497

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);