issue_comments: 533693878

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/3324#issuecomment-533693878 https://api.github.com/repos/pydata/xarray/issues/3324 533693878 MDEyOklzc3VlQ29tbWVudDUzMzY5Mzg3OA== 2818208 2019-09-20T20:13:07Z 2019-09-20T20:13:07Z CONTRIBUTOR

This could be an addition to the either_dict_or_kwargs helper function.

Currently, either_dict_or_kwargs doesn't have access to the DataArray instance's dims or the function's keyword arguments; are you suggesting that either_dict_or_kwargs be modified to take these? I do like this approach. Otherwise, I'd have to add a second utility function check everywhere either_dict_or_kwargs is used, and it'd be easy to forget going forward.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   495920497