issue_comments

Table actions

2 rows where issue = 492966281 and user = 81219 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • huard · 2 ✖

issue 1

  • DataArray.quantile does not honor `keep_attrs` · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
530962306 https://github.com/pydata/xarray/issues/3304#issuecomment-530962306 https://api.github.com/repos/pydata/xarray/issues/3304 MDEyOklzc3VlQ29tbWVudDUzMDk2MjMwNg== huard 81219 2019-09-12T19:04:09Z 2019-09-12T19:04:09Z CONTRIBUTOR

Ok, I'll submit a PR shortly. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DataArray.quantile does not honor `keep_attrs` 492966281
530960436 https://github.com/pydata/xarray/issues/3304#issuecomment-530960436 https://api.github.com/repos/pydata/xarray/issues/3304 MDEyOklzc3VlQ29tbWVudDUzMDk2MDQzNg== huard 81219 2019-09-12T18:58:58Z 2019-09-12T18:58:58Z CONTRIBUTOR

Looking at the code, I'm confused. The DataArray.quantile method creates a temporary dataset, copies the variable over, calls the Variable.quantile method, then assigns the attributes from the dataset to this new variable. At no point however are attributes assigned to this temporary dataset. My understanding is that Variable.quantile should have a keep_attrs argument, correct ?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DataArray.quantile does not honor `keep_attrs` 492966281

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);