home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 530960436

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/3304#issuecomment-530960436 https://api.github.com/repos/pydata/xarray/issues/3304 530960436 MDEyOklzc3VlQ29tbWVudDUzMDk2MDQzNg== 81219 2019-09-12T18:58:58Z 2019-09-12T18:58:58Z CONTRIBUTOR

Looking at the code, I'm confused. The DataArray.quantile method creates a temporary dataset, copies the variable over, calls the Variable.quantile method, then assigns the attributes from the dataset to this new variable. At no point however are attributes assigned to this temporary dataset. My understanding is that Variable.quantile should have a keep_attrs argument, correct ?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  492966281
Powered by Datasette · Queries took 0.748ms · About: xarray-datasette