issue_comments

Table actions

2 rows where issue = 490618213 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: updated_at (date)

These facets timed out: author_association

user 1

  • shoyer · 2 ✖

issue 1

  • xr.DataSet.from_dataframe / xr.DataArray.from_series does not preserve DateTimeIndex with timezone · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
824354016 https://github.com/pydata/xarray/issues/3291#issuecomment-824354016 https://api.github.com/repos/pydata/xarray/issues/3291 MDEyOklzc3VlQ29tbWVudDgyNDM1NDAxNg== shoyer 1217238 2021-04-21T20:59:18Z 2021-04-21T21:00:41Z MEMBER

If ds["time"] is a 1D indexed coordinate, is ds["time"].data ≡ ds.indexes["time"].data? If so, that would just be a pd.DatetimeIndex which is timezone-aware and then this problem is solved because we don't maintain a separate numpy array. Am I understanding this correctly?

No, unfortunate it is not possible to use a pandas.Index directly inside Variable.data, because pandas.Index is not compatible with the NumPy array API -- in particular it is stuck with 1D data. Instead, we will need to wrap the array in some adapter class to make it compatible. Ideally this wrapper would be a fully N-dimensional wrapper for pandas.Series objects, but for a first pass it would probably be fine to raise an error if indexing would create a higher dimensional array.

The bigger issue is that elsewhere in Xarray probably needs updates to avoid assuming that all dtype objects are numpy.dtype instances.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xr.DataSet.from_dataframe / xr.DataArray.from_series does not preserve DateTimeIndex with timezone 490618213
531522690 https://github.com/pydata/xarray/issues/3291#issuecomment-531522690 https://api.github.com/repos/pydata/xarray/issues/3291 MDEyOklzc3VlQ29tbWVudDUzMTUyMjY5MA== shoyer 1217238 2019-09-15T00:00:37Z 2019-09-15T00:00:37Z MEMBER

You should be getting a warning about this if you use the latest version of pandas. In the future, this behavior will change to return an object dtype array full of pandas Datetime objects. Unfortunately NumPy doesn't have a built-in datetime with time-zone stype, so this is about the best we can do.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   xr.DataSet.from_dataframe / xr.DataArray.from_series does not preserve DateTimeIndex with timezone 490618213

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);