issue_comments

Table actions

5 rows where issue = 485390288 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Clarify documentation of argmin/argmax · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
675626899 https://github.com/pydata/xarray/issues/3264#issuecomment-675626899 https://api.github.com/repos/pydata/xarray/issues/3264 MDEyOklzc3VlQ29tbWVudDY3NTYyNjg5OQ== rdrussotto 13667821 2020-08-18T17:57:34Z 2020-08-18T17:57:34Z CONTRIBUTOR

@sjvrijn The new documentation looks great, with examples illustrating how it works! idxmin/idxmax is also a great addition. I think all of the concerns I raised in this issue are resolved.

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Clarify documentation of argmin/argmax 485390288
670967112 https://github.com/pydata/xarray/issues/3264#issuecomment-670967112 https://api.github.com/repos/pydata/xarray/issues/3264 MDEyOklzc3VlQ29tbWVudDY3MDk2NzExMg== sjvrijn 8833517 2020-08-08T19:49:25Z 2020-08-08T19:49:36Z CONTRIBUTOR

@rdrussotto Since v0.16.0 (specifically https://github.com/pydata/xarray/commit/bdcfab524ef1c852abe6dabcfabc7292f058fddc), argmin/argmax have been explicitly defined with dedicated docstrings. Is the issue you raised still a problem?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Clarify documentation of argmin/argmax 485390288
576075198 https://github.com/pydata/xarray/issues/3264#issuecomment-576075198 https://api.github.com/repos/pydata/xarray/issues/3264 MDEyOklzc3VlQ29tbWVudDU3NjA3NTE5OA== rdrussotto 13667821 2020-01-20T01:45:59Z 2020-01-20T01:45:59Z CONTRIBUTOR

Actually, maybe just an if statement in "inject_reduce_methods" conditioned on the name of the function would work for switching to a different template. I might give this a try later.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Clarify documentation of argmin/argmax 485390288
576074412 https://github.com/pydata/xarray/issues/3264#issuecomment-576074412 https://api.github.com/repos/pydata/xarray/issues/3264 MDEyOklzc3VlQ29tbWVudDU3NjA3NDQxMg== rdrussotto 13667821 2020-01-20T01:40:26Z 2020-01-20T01:41:54Z CONTRIBUTOR

Turns out this is more difficult than I thought... I did some digging into where these doc pages are defined (e.g. http://xarray.pydata.org/en/stable/generated/xarray.Dataset.argmin.html) and realized they are auto-generated from a template in core/ops.py, which is the same for various "reduce" functions, most of which are more self-explanatory like max or min. Creating more useful doc page for argmin/argmax would, I believe, require writing a new template for them, which would in turn require separating argmin and argmax from "NAN_REDUCE_METHODS" and writing a new "inject" function for them. This would mess up a lot of other places that use the "inject_reduce_methods" function. Not sure if this is worth the effort especially since @shoyer left a todo note saying he's going to rewrite this module anyway.

It might still be worth adding an example use case of argmax/argmin, maybe finding the dates of the highest and lowest temperatures in the toy weather data example.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Clarify documentation of argmin/argmax 485390288
524991089 https://github.com/pydata/xarray/issues/3264#issuecomment-524991089 https://api.github.com/repos/pydata/xarray/issues/3264 MDEyOklzc3VlQ29tbWVudDUyNDk5MTA4OQ== max-sixty 5635139 2019-08-26T19:12:33Z 2019-08-26T19:18:07Z MEMBER

Thanks for the issue @rdrussotto - would definitely take a PR for this (even if it's a unsophisticated copy-paste of a snippet of the numpy docs)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Clarify documentation of argmin/argmax 485390288

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);