home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 576074412

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/3264#issuecomment-576074412 https://api.github.com/repos/pydata/xarray/issues/3264 576074412 MDEyOklzc3VlQ29tbWVudDU3NjA3NDQxMg== 13667821 2020-01-20T01:40:26Z 2020-01-20T01:41:54Z CONTRIBUTOR

Turns out this is more difficult than I thought... I did some digging into where these doc pages are defined (e.g. http://xarray.pydata.org/en/stable/generated/xarray.Dataset.argmin.html) and realized they are auto-generated from a template in core/ops.py, which is the same for various "reduce" functions, most of which are more self-explanatory like max or min. Creating more useful doc page for argmin/argmax would, I believe, require writing a new template for them, which would in turn require separating argmin and argmax from "NAN_REDUCE_METHODS" and writing a new "inject" function for them. This would mess up a lot of other places that use the "inject_reduce_methods" function. Not sure if this is worth the effort especially since @shoyer left a todo note saying he's going to rewrite this module anyway.

It might still be worth adding an example use case of argmax/argmin, maybe finding the dates of the highest and lowest temperatures in the toy weather data example.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  485390288
Powered by Datasette · Queries took 1.271ms · About: xarray-datasette