issue_comments

Table actions

4 rows where issue = 482663274 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

issue 1

  • Explicitly keep track of indexes with merging · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
538230448 https://github.com/pydata/xarray/pull/3234#issuecomment-538230448 https://api.github.com/repos/pydata/xarray/issues/3234 MDEyOklzc3VlQ29tbWVudDUzODIzMDQ0OA== shoyer 1217238 2019-10-04T04:43:12Z 2019-10-04T04:43:12Z MEMBER

@max-sixty thanks for taking a look!

I agree, this was hard to review without test changes.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Explicitly keep track of indexes with merging 482663274
534837855 https://github.com/pydata/xarray/pull/3234#issuecomment-534837855 https://api.github.com/repos/pydata/xarray/issues/3234 MDEyOklzc3VlQ29tbWVudDUzNDgzNzg1NQ== max-sixty 5635139 2019-09-25T03:42:01Z 2019-09-25T03:42:01Z MEMBER

I had a read through—looks good, better design (and lots of nice idioms!). But I confess that I don't know the code well enough to make a more helpful judgement, and while I'd normally approach from the tests, no changes to those.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Explicitly keep track of indexes with merging 482663274
534828097 https://github.com/pydata/xarray/pull/3234#issuecomment-534828097 https://api.github.com/repos/pydata/xarray/issues/3234 MDEyOklzc3VlQ29tbWVudDUzNDgyODA5Nw== shoyer 1217238 2019-09-25T02:49:22Z 2019-09-25T02:49:22Z MEMBER

@pydata/xarray if anyone has time, it would be great to get a review here.

(I think this is pretty low risk, so I will probably self merge this in a week or so if there aren't any reviews) 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Explicitly keep track of indexes with merging 482663274
523151224 https://github.com/pydata/xarray/pull/3234#issuecomment-523151224 https://api.github.com/repos/pydata/xarray/issues/3234 MDEyOklzc3VlQ29tbWVudDUyMzE1MTIyNA== shoyer 1217238 2019-08-20T19:00:25Z 2019-08-20T19:00:25Z MEMBER

Test failure should be fixed by https://github.com/pydata/xarray/pull/3235

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Explicitly keep track of indexes with merging 482663274

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);