issue_comments: 534837855

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3234#issuecomment-534837855 https://api.github.com/repos/pydata/xarray/issues/3234 534837855 MDEyOklzc3VlQ29tbWVudDUzNDgzNzg1NQ== 5635139 2019-09-25T03:42:01Z 2019-09-25T03:42:01Z MEMBER

I had a read through—looks good, better design (and lots of nice idioms!). But I confess that I don't know the code well enough to make a more helpful judgement, and while I'd normally approach from the tests, no changes to those.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   482663274