issue_comments

Table actions

4 rows where issue = 482561245 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • Drop keyword support: small fixes · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
524459449 https://github.com/pydata/xarray/pull/3233#issuecomment-524459449 https://api.github.com/repos/pydata/xarray/issues/3233 MDEyOklzc3VlQ29tbWVudDUyNDQ1OTQ0OQ== pep8speaks 24736507 2019-08-23T20:56:09Z 2019-08-23T20:57:22Z NONE

Hello @gwgundersen! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-08-23 20:57:22 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop keyword support: small fixes 482561245
523196966 https://github.com/pydata/xarray/pull/3233#issuecomment-523196966 https://api.github.com/repos/pydata/xarray/issues/3233 MDEyOklzc3VlQ29tbWVudDUyMzE5Njk2Ng== gwgundersen 2818208 2019-08-20T21:12:58Z 2019-08-20T21:12:58Z CONTRIBUTOR

@shoyer, I've addressed your comments by adding more helpful warnings and testing that said warnings are raised properly. I've also moved both warnings to the top of the function as I think it's a bit easier to reason about the code branches this way.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop keyword support: small fixes 482561245
522815334 https://github.com/pydata/xarray/pull/3233#issuecomment-522815334 https://api.github.com/repos/pydata/xarray/issues/3233 MDEyOklzc3VlQ29tbWVudDUyMjgxNTMzNA== max-sixty 5635139 2019-08-20T01:29:38Z 2019-08-20T01:29:38Z MEMBER

The failure is b/c of an upstream package; we can ignore

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop keyword support: small fixes 482561245
522787266 https://github.com/pydata/xarray/pull/3233#issuecomment-522787266 https://api.github.com/repos/pydata/xarray/issues/3233 MDEyOklzc3VlQ29tbWVudDUyMjc4NzI2Ng== gwgundersen 2818208 2019-08-19T23:06:51Z 2019-08-19T23:06:51Z CONTRIBUTOR

Strange. This passes all my tests locally.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Drop keyword support: small fixes 482561245

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);