issue_comments: 523196966

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3233#issuecomment-523196966 https://api.github.com/repos/pydata/xarray/issues/3233 523196966 MDEyOklzc3VlQ29tbWVudDUyMzE5Njk2Ng== 2818208 2019-08-20T21:12:58Z 2019-08-20T21:12:58Z CONTRIBUTOR

@shoyer, I've addressed your comments by adding more helpful warnings and testing that said warnings are raised properly. I've also moved both warnings to the top of the function as I think it's a bit easier to reason about the code branches this way.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   482561245