issue_comments

Table actions

3 rows where issue = 481935553 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Add PR checklist to contributing docs · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
522340962 https://github.com/pydata/xarray/pull/3226#issuecomment-522340962 https://api.github.com/repos/pydata/xarray/issues/3226 MDEyOklzc3VlQ29tbWVudDUyMjM0MDk2Mg== max-sixty 5635139 2019-08-18T17:40:44Z 2019-08-18T17:40:44Z MEMBER

Thanks again @gwgundersen 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add PR checklist to contributing docs 481935553
522340939 https://github.com/pydata/xarray/pull/3226#issuecomment-522340939 https://api.github.com/repos/pydata/xarray/issues/3226 MDEyOklzc3VlQ29tbWVudDUyMjM0MDkzOQ== max-sixty 5635139 2019-08-18T17:40:25Z 2019-08-18T17:40:25Z MEMBER

For example, while it's true that you need to know about git before contributing, how many people need to learn git or forking or creating branches when first contributing? My guess is that this is the minority, and the docs could reflect this by putting such reference material near the bottom of the page.

💯 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add PR checklist to contributing docs 481935553
522299956 https://github.com/pydata/xarray/pull/3226#issuecomment-522299956 https://api.github.com/repos/pydata/xarray/issues/3226 MDEyOklzc3VlQ29tbWVudDUyMjI5OTk1Ng== gwgundersen 2818208 2019-08-18T07:53:07Z 2019-08-18T07:53:07Z CONTRIBUTOR

I did not want to overreach with this PR, but I agree that the documentation is verbose. It seems to follow a logical order of information without making reasonable assumptions about the contributor. I think the docs would be better suited following an inverted pyramid of information. In that light, something like this PR checklist or an overview would be at the top with quick links to more detailed information at the bottom.

For example, while it's true that you need to know about git before contributing, how many people need to learn git or forking or creating branches when first contributing? My guess is that this is the minority, and the docs could reflect this by putting such reference material near the bottom of the page.

Also added a note to "What's new".

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add PR checklist to contributing docs 481935553

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);